Add favicon fallback for browser compatibility#12
Conversation
- Convert SVG favicon to multi-size ICO (16-256px) using ImageMagick - Place favicon.ico in docs root for automatic browser discovery - Add main.html override to include ICO link in HTML head
Automatically converts logo/icon.svg to multi-size ICO format when the source SVG is updated on main/master branch.
|
Note Reviews pausedUse the following commands to manage reviews:
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdds an automated GitHub Actions workflow that converts Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Trigger as "Push / workflow_dispatch"
participant Actions as "GitHub Actions"
participant Runner as "Ubuntu Runner"
participant IM as "ImageMagick"
participant Repo as "Repository"
participant PRAction as "create-pull-request Action"
Trigger->>Actions: workflow starts
Actions->>Runner: run update-favicon job
Runner->>Repo: checkout repository
Runner->>IM: convert `logo/icon.svg` -> multi-size `favicon.ico` files
IM-->>Runner: generated `docs/assets/images/favicon.ico`, `docs/favicon.ico`
Runner->>Runner: diff generated files vs repo files
alt changes detected
Runner->>PRAction: create branch, commit updated favicon files
PRAction->>Repo: push branch and open pull request
else no changes
Runner-->>Actions: exit without PR
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- git diff --quiet doesn't detect untracked files after fresh convert - git status --porcelain detects both new and modified files - mkdir -p ensures directory exists on fresh clone
- Respects branch protection rules - Creates visible PR for review - Adds chore and area: ci/cd labels - Uses signed commits
- Ubuntu's imagemagick package provides IM6 with convert, not IM7 magick - Also adds wip label and coderabbit config updates
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: Kaj Kowalski <info@kajkowalski.nl>
Chores
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.