Skip to content

Is SwiftLint supposed to be used for all algorithms? #940

Open
@RobertoMachorro

Description

@RobertoMachorro

Brief Intro

I see the install_swiftlint.sh script and .swiftlint.yml config file in the root folder and assume that it's meant to check the algorithm implementations. But currently when swiftlint is run, it returns:

Done linting! Found 2070 violations, 81 serious in 378 files.

More Details

Is the intent for all algorithms to pass linting? If that is the case, would it be helpful to fix these issues and then to setup a GitHub Workflow / Action to test this in future Pull Requests and Master Commits?

Edit: The .swiftlint.yml is not ok with one letter variable names, which I appreciate, but typically puts those one letter variables in loops in a tough situation - and those are common in everyone's code. I suggest opting out of that rule?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions