Fix lint issues (#3023)

Author: martinmaly

porch/apiserver/pkg/registry/porch/packagerevision.go

@@ -107,7 +107,7 @@ func (r *packageRevisions) Create(ctx context.Context, runtimeObject runtime.Obj
 
 	repositoryName := obj.Spec.RepositoryName
 	if repositoryName == "" {
-		return nil, apierrors.NewBadRequest(fmt.Sprintf("spec.repositoryName is required"))
+		return nil, apierrors.NewBadRequest("spec.repositoryName is required")
 	}
 
 	var repositoryObj configapi.Repository

porch/func/internal/podevaluator.go

@@ -23,7 +23,6 @@ import (
 	"time"
 
 	"github.com/GoogleContainerTools/kpt/porch/func/evaluator"
-	pb "github.com/GoogleContainerTools/kpt/porch/func/evaluator"
 	"github.com/google/go-containerregistry/pkg/authn"
 	"github.com/google/go-containerregistry/pkg/name"
 	"github.com/google/go-containerregistry/pkg/v1/remote"
@@ -72,7 +71,7 @@ func NewPodEvaluator(namespace, wrapperServerImage string) (Evaluator, error) {
 	}, nil
 }
 
-func (pe *podEvaluator) EvaluateFunction(ctx context.Context, req *pb.EvaluateFunctionRequest) (*pb.EvaluateFunctionResponse, error) {
+func (pe *podEvaluator) EvaluateFunction(ctx context.Context, req *evaluator.EvaluateFunctionRequest) (*evaluator.EvaluateFunctionResponse, error) {
 	ref, err := name.ParseReference(req.Image)
 	if err != nil {
 		return nil, err
@@ -83,6 +82,10 @@ func (pe *podEvaluator) EvaluateFunction(ctx context.Context, req *pb.EvaluateFu
 	}
 	// TODO: cache the config file
 	cf, err := img.ConfigFile()
+	if err != nil {
+		return nil, err
+	}
+
 	cfg := cf.Config
 	var fnCmd []string
 	if len(cfg.Entrypoint) != 0 {

porch/repository/pkg/git/primitives_test.go

@@ -22,7 +22,6 @@ import (
 	"time"
 
 	"github.com/go-git/go-git/v5"
-	gogit "github.com/go-git/go-git/v5"
 	"github.com/go-git/go-git/v5/config"
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/go-git/go-git/v5/plumbing/object"
@@ -403,7 +402,7 @@ func TestDeleteUpstreamBranches(t *testing.T) {
 	// Refetch
 	switch err := downstream.Fetch(&git.FetchOptions{
 		RemoteName: OriginName,
-		Tags:       gogit.NoTags,
+		Tags:       git.NoTags,
 		Prune:      git.Prune,
 	}); err {
 	case nil, git.NoErrAlreadyUpToDate: