Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR Python client, local dev, make test-e2e, using Podman #766

Open
tarilabs opened this issue Feb 6, 2025 · 0 comments
Open

MR Python client, local dev, make test-e2e, using Podman #766

tarilabs opened this issue Feb 6, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@tarilabs
Copy link
Member

tarilabs commented Feb 6, 2025

When using Podman (desktop) and testing locally the MR Python client
seems to me in order for the locally built image to be

docker build . -f Dockerfile -t kubeflow/model-registry:latest --load

with the --load argument, otheriwise:

 => CACHED [stage-1 2/3] COPY --from=builder /workspace/model-registry .                                                                                                                                                                        0.0s
WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
+ [[ -n 1 ]]
+ CLUSTER_NAME=kind
+ echo 'Creating local Kind cluster and loading image'
Creating local Kind cluster and loading image
++ kind get clusters
+ [[ kind =~ kind ]]
+ echo 'Cluster already exists, skipping creation'
Cluster already exists, skipping creation
+ kubectl config use-context kind-kind
Switched to context "kind-kind".
+ kind load docker-image -n kind kubeflow/model-registry:latest
ERROR: image: "kubeflow/model-registry:latest" not present locally

My suggestion is to have argument passing here:

cd ../../ && IMG_VERSION=${IMG_VERSION} make image/build && LOCAL=1 ./scripts/deploy_on_kind.sh

and for the make image command to accept additional parameters, in this case --load.

@tarilabs tarilabs added the good first issue Good for newcomers label Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant