fix: cancel button variant and expandable spacing #737
+361
−362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
added
the
area/frontend
google-oss-prow
bot
added
area/v2
Signed-off-by: Jenny <[email protected]>
jenny-s51
force-pushed
the
cancel-btn-and-expandable-fix
branch
from
39f4446 to
2a4fe40
Compare
ederign
approved these changes
Nov 10, 2025
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/ok-to-test |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #716 #717
What changed:
isInlineprop removed on "Cancel" buttons - no longer showing underline. (Applies "link" variant):2) Added `Stack` layout with gutter to resolve spacing issue:
Before:
After:
cc @tobiastal, per your feedback