VolumeGroupSnapshot error status not updated

[torirevilla]

What happened:
When the storage vendor returns a status.error code INVALID_ARGUMENT or FAILED_PRECONDITION the VolumeGroupSnapshot is not updated with a status and continues to call the storage vendor to retry the operation. To the end user this looks like the VolumeGroupSnapshot is waiting on the storage vendor and is simply not ready yet, in reality the storage vendor has returned an error stating that a retry will not work.

What you expected to happen:
The VolumeGroupSnapshot should be updated to include the returned error and if appropriate (depending on the error) retry or not retry.
There should be a list of terminal error codes that the snapshotter would not retry,INVALID_ARGUMENT and FAILED_PRECONDITION are a few but there could be more.

How to reproduce it:

1. Create a VolumeGroupSnapshot using a configuration not supported by storage vendor that would trigger a non retry-able error to be returned.

Anything else we need to know?:

Environment:

• Driver version: v8.2.1
• Kubernetes version (use kubectl version): v1.33.2
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:
  --feature-gates=CSIVolumeGroupSnapshot=true