Merge pull request #2334 from torredil/fsr-log-523241

k8s-ci-robot · web-flow · commit 8b7de7ec61d4 · 2025-02-11T12:37:58.000-08:00
Fix raw pointer log in `EnableFastSnapshotRestores`
diff --git a/pkg/cloud/cloud.go b/pkg/cloud/cloud.go
@@ -1431,7 +1431,13 @@ func (c *cloud) EnableFastSnapshotRestores(ctx context.Context, availabilityZone
 		return nil, err
 	}
 	if len(response.Unsuccessful) > 0 {
-		return response, fmt.Errorf("failed to create fast snapshot restores for snapshot %s: %v", snapshotID, response.Unsuccessful)
+		var errDetails []string
+		for _, r := range response.Unsuccessful {
+			for _, e := range r.FastSnapshotRestoreStateErrors {
+				errDetails = append(errDetails, fmt.Sprintf("Error Code: %s, Error Message: %s", aws.ToString(e.Error.Code), aws.ToString(e.Error.Message)))
+			}
+		}
+		return nil, errors.New(strings.Join(errDetails, "; "))
 	}
 	return response, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -1431,7 +1431,13 @@ func (c *cloud) EnableFastSnapshotRestores(ctx context.Context, availabilityZone`
`1431`	`1431`	`return nil, err`
`1432`	`1432`	`}`
`1433`	`1433`	`if len(response.Unsuccessful) > 0 {`
`1434`		`- return response, fmt.Errorf("failed to create fast snapshot restores for snapshot %s: %v", snapshotID, response.Unsuccessful)`
	`1434`	`+ var errDetails []string`
	`1435`	`+ for _, r := range response.Unsuccessful {`
	`1436`	`+ for _, e := range r.FastSnapshotRestoreStateErrors {`
	`1437`	`+ errDetails = append(errDetails, fmt.Sprintf("Error Code: %s, Error Message: %s", aws.ToString(e.Error.Code), aws.ToString(e.Error.Message)))`
	`1438`	`+ }`
	`1439`	`+ }`
	`1440`	`+ return nil, errors.New(strings.Join(errDetails, "; "))`
`1435`	`1441`	`}`
`1436`	`1442`	`return response, nil`
`1437`	`1443`	`}`