Skip to content

Commit 7524c68

Browse files
committed
chore: change tgb field to lowercase everywhere to avoid logs dropped due to conflict in OS/ES
Signed-off-by: Daniel Brown <[email protected]>
1 parent d0df42b commit 7524c68

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

controllers/elbv2/targetgroupbinding_deferred_reconciler.go

+7-6
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,16 @@ package controllers
22

33
import (
44
"context"
5+
"math/rand"
6+
"time"
7+
58
"github.com/go-logr/logr"
69
"k8s.io/apimachinery/pkg/types"
710
"k8s.io/client-go/util/workqueue"
8-
"math/rand"
911
elbv2api "sigs.k8s.io/aws-load-balancer-controller/apis/elbv2/v1beta1"
1012
"sigs.k8s.io/aws-load-balancer-controller/pkg/k8s"
1113
"sigs.k8s.io/aws-load-balancer-controller/pkg/targetgroupbinding"
1214
"sigs.k8s.io/controller-runtime/pkg/client"
13-
"time"
1415
)
1516

1617
const (
@@ -56,7 +57,7 @@ func (d *deferredTargetGroupBindingReconcilerImpl) Enqueue(tgb *elbv2api.TargetG
5657
nsn := k8s.NamespacedName(tgb)
5758
if d.isEligibleForDefer(tgb) {
5859
d.enqueue(nsn)
59-
d.logger.Info("enqueued new deferred TGB", "TGB", nsn.Name)
60+
d.logger.Info("enqueued new deferred TGB", "tgb", nsn.Name)
6061
}
6162
}
6263

@@ -88,7 +89,7 @@ func (d *deferredTargetGroupBindingReconcilerImpl) handleDeferredItem(nsn types.
8889

8990
// Re-check that this tgb hasn't been updated since it was enqueued
9091
if !d.isEligibleForDefer(tgb) {
91-
d.logger.Info("TGB not eligible for deferral", "TGB", nsn)
92+
d.logger.Info("TGB not eligible for deferral", "tgb", nsn)
9293
return
9394
}
9495

@@ -99,13 +100,13 @@ func (d *deferredTargetGroupBindingReconcilerImpl) handleDeferredItem(nsn types.
99100
d.handleDeferredItemError(nsn, err, "Failed to reset TGB checkpoint")
100101
return
101102
}
102-
d.logger.Info("TGB checkpoint reset", "TGB", nsn)
103+
d.logger.Info("TGB checkpoint reset", "tgb", nsn)
103104
}
104105

105106
func (d *deferredTargetGroupBindingReconcilerImpl) handleDeferredItemError(nsn types.NamespacedName, err error, msg string) {
106107
err = client.IgnoreNotFound(err)
107108
if err != nil {
108-
d.logger.Error(err, msg, "TGB", nsn)
109+
d.logger.Error(err, msg, "tgb", nsn)
109110
d.enqueue(nsn)
110111
}
111112
}

0 commit comments

Comments
 (0)