Skip to content

Add support for resources (CPU/memory) shares level #4198

Description

@fad3t

/kind feature

Describe the solution you'd like
The vSphereMachineTemplate currently exposes resources shares via .spec.template.spec.resources.shares, however it only accepts integers (so shares level = custom I guess).

I think it would be nice to add support for other shares levels, via a new field where users could specify "normal", "low", or "high". If level is set to "custom", then the current value (integer) would be used.

We could either add a new field (sharesLevel) or review the existing API (cleaner, but breaking).

Please let me know what you think. I could propose a PR if needed, but I'd like to confirm the solution first.
Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions