Skip to content

Commit 531ea31

Browse files
committed
machinepool: set v1beta2 Paused condition
1 parent 0fb3085 commit 531ea31

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

exp/internal/controllers/machinepool_controller.go

+3-6
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ import (
4444
expv1 "sigs.k8s.io/cluster-api/exp/api/v1beta1"
4545
"sigs.k8s.io/cluster-api/internal/util/ssa"
4646
"sigs.k8s.io/cluster-api/util"
47-
"sigs.k8s.io/cluster-api/util/annotations"
4847
"sigs.k8s.io/cluster-api/util/conditions"
4948
"sigs.k8s.io/cluster-api/util/finalizers"
5049
"sigs.k8s.io/cluster-api/util/patch"
50+
"sigs.k8s.io/cluster-api/util/paused"
5151
"sigs.k8s.io/cluster-api/util/predicates"
5252
)
5353

@@ -116,7 +116,6 @@ func (r *MachinePoolReconciler) SetupWithManager(ctx context.Context, mgr ctrl.M
116116
// TODO: should this wait for Cluster.Status.InfrastructureReady similar to Infra Machine resources?
117117
builder.WithPredicates(
118118
predicates.All(mgr.GetScheme(), predicateLog,
119-
predicates.ClusterUnpaused(mgr.GetScheme(), predicateLog),
120119
predicates.ResourceHasFilterLabel(mgr.GetScheme(), predicateLog, r.WatchFilterValue),
121120
),
122121
),
@@ -167,10 +166,8 @@ func (r *MachinePoolReconciler) Reconcile(ctx context.Context, req ctrl.Request)
167166
mp.Spec.ClusterName, mp.Name, mp.Namespace)
168167
}
169168

170-
// Return early if the object or Cluster is paused.
171-
if annotations.IsPaused(cluster, mp) {
172-
log.Info("Reconciliation is paused for this object")
173-
return ctrl.Result{}, nil
169+
if isPaused, conditionChanged, err := paused.EnsurePausedCondition(ctx, r.Client, cluster, mp); err != nil || isPaused || conditionChanged {
170+
return ctrl.Result{}, err
174171
}
175172

176173
// Initialize the patch helper.

0 commit comments

Comments
 (0)