Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log when upsert or create ignores a command #4815

Open
davhdavh opened this issue Oct 17, 2024 · 2 comments · May be fixed by #4816
Open

Log when upsert or create ignores a command #4815

davhdavh opened this issue Oct 17, 2024 · 2 comments · May be fixed by #4816
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@davhdavh
Copy link
Contributor

What would you like to be added:

The way the Policy class is implemented, it will silently drop the entire range of endpoints to update without any notification on what or
why it does this.

e.g. here the list of Deletes are just dropped:

external-dns/plan/policy.go

Lines 44 to 48 in 59b2438

return &Changes{
Create: changes.Create,
UpdateOld: changes.UpdateOld,
UpdateNew: changes.UpdateNew,
}

Please add a log that reports which entries are ignored in

external-dns/plan/policy.go

Line 44 in 59b2438

return &Changes{
and

external-dns/plan/policy.go

Line 56 in 59b2438

return &Changes{

Why is this needed:

external-dns is too much of a blackbox that just does its own thing and hard to tell why.
@davhdavh davhdavh added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 17, 2024
@davhdavh davhdavh linked a pull request Oct 17, 2024 that will close this issue
Open
2 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add logs for policy ignores davhdavh/external-dns
3 participants
@davhdavh @k8s-ci-robot @k8s-triage-robot