You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in addition to other e2e related open issue #619 and #486 there are few minor issues in e2e tests as specified by @danehans in one of the comments in PR review - #485 (review)
e2e test should perform cleanup when getting timeout. after further investigation I've noticed the curl command doesn't define a timeout and therefore if the command doesn't work it will hang until the test fails, but will not perform a cleanup since the curl doesn't return an error.
the fix to this issue should be straight forward by adding a timeout to the curl command.
HF_TOKEN env var should be checked at the beginning of the test setup in order to fail fast in case it's not defined.
The text was updated successfully, but these errors were encountered:
in addition to other e2e related open issue #619 and #486 there are few minor issues in e2e tests as specified by @danehans in one of the comments in PR review - #485 (review)
e2e test should perform cleanup when getting timeout. after further investigation I've noticed the curl command doesn't define a timeout and therefore if the command doesn't work it will hang until the test fails, but will not perform a cleanup since the curl doesn't return an error.
the fix to this issue should be straight forward by adding a timeout to the curl command.
HF_TOKEN env var should be checked at the beginning of the test setup in order to fail fast in case it's not defined.
The text was updated successfully, but these errors were encountered: