Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

few minor issues in e2e tests #620

Closed
nirrozenbaum opened this issue Mar 31, 2025 · 1 comment · Fixed by #621
Closed

few minor issues in e2e tests #620

nirrozenbaum opened this issue Mar 31, 2025 · 1 comment · Fixed by #621
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@nirrozenbaum
Copy link
Contributor

in addition to other e2e related open issue #619 and #486 there are few minor issues in e2e tests as specified by @danehans in one of the comments in PR review - #485 (review)

  • e2e test should perform cleanup when getting timeout. after further investigation I've noticed the curl command doesn't define a timeout and therefore if the command doesn't work it will hang until the test fails, but will not perform a cleanup since the curl doesn't return an error.
    the fix to this issue should be straight forward by adding a timeout to the curl command.

  • HF_TOKEN env var should be checked at the beginning of the test setup in order to fail fast in case it's not defined.

@nirrozenbaum nirrozenbaum added the kind/bug Categorizes issue or PR as related to a bug. label Mar 31, 2025
@nirrozenbaum
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant