Skip to content

Commit b7ab3ab

Browse files
committed
Add examples with valid and invalid header values
Signed-off-by: Norwin Schnyder <[email protected]>
1 parent 0a5580a commit b7ab3ab

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

examples/experimental/http-response-header.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ spec:
2020
value: header-add-2
2121
- name: X-Header-Add-3
2222
value: header-add-3
23+
- name: Content-Disposition
24+
value: "attachment; filename=\"example_file.txt\""
2325
backendRefs:
2426
- name: echo
2527
port: 8080
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
apiVersion: gateway.networking.k8s.io/v1
2+
kind: HTTPRoute
3+
metadata:
4+
name: invalid-header-value
5+
spec:
6+
rules:
7+
- filters:
8+
- type: ResponseHeaderModifier
9+
responseHeaderModifier:
10+
add:
11+
- name: X-Test-Header
12+
value: "this\nis\rinvalid\r\nvalue"

pkg/generator/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ func gatewayTweaks(channel string, name string, jsonProps apiext.JSONSchemaProps
225225
if len(patternMatch) != 2 {
226226
log.Fatalf("Invalid %s Pattern tag for %s", validationPrefix, name)
227227
}
228-
228+
229229
numValid++
230230
jsonProps.Pattern = patternMatch[1]
231231
}

0 commit comments

Comments
 (0)