Warn and continue instead of erroring for bad disk topology parameters

Author: julianKatz

pkg/common/parameters.go

@@ -20,6 +20,8 @@ import (
 	"fmt"
 	"strconv"
 	"strings"
+
+	"k8s.io/klog/v2"
 )
 
 const (
@@ -326,12 +328,14 @@ func (pp *ParameterProcessor) ExtractAndDefaultParameters(parameters map[string]
 			}
 		case ParameterKeyUseAllowedDiskTopology:
 			if !pp.EnableDiskTopology {
-				return p, d, fmt.Errorf("parameters contains invalid option %q when disk topology is not enabled", ParameterKeyUseAllowedDiskTopology)
+				klog.Warningf("parameters contains invalid option %q when disk topology is not enabled", ParameterKeyUseAllowedDiskTopology)
+				continue
 			}
 
 			paramUseAllowedDiskTopology, err := ConvertStringToBool(v)
 			if err != nil {
-				return p, d, fmt.Errorf("failed to convert %s parameter with value %q to bool: %w", ParameterKeyUseAllowedDiskTopology, v, err)
+				klog.Warningf("failed to convert %s parameter with value %q to bool: %v", ParameterKeyUseAllowedDiskTopology, v, err)
+				continue
 			}
 
 			p.UseAllowedDiskTopology = paramUseAllowedDiskTopology

pkg/common/parameters_test.go

@@ -467,15 +467,37 @@ func TestExtractAndDefaultParameters(t *testing.T) {
 			},
 		},
 		{
-			name:       "useAllowedDiskTopology specified, disk topology feature disabled",
-			parameters: map[string]string{ParameterKeyUseAllowedDiskTopology: "foo-bar"},
-			expectErr:  true,
+			// Disk topology feature shouldn't cause parameter parsing to fail, even when misconfigured.
+			name: "useAllowedDiskTopology specified, disk topology feature disabled",
+			parameters: map[string]string{
+				ParameterKeyUseAllowedDiskTopology: "true", // Correct type: boolean string.
+			},
+			labels: map[string]string{},
+			expectParams: DiskParameters{
+				DiskType:             "pd-standard",
+				ReplicationType:      "none",
+				DiskEncryptionKMSKey: "",
+				Tags:                 map[string]string{},
+				Labels:               map[string]string{},
+				ResourceTags:         map[string]string{},
+			},
 		},
 		{
+			// Disk topology feature shouldn't cause parameter parsing to fail, even when misconfigured.
 			name:               "useAllowedDiskTopology specified, wrong type",
-			parameters:         map[string]string{ParameterKeyUseAllowedDiskTopology: "123"},
 			enableDiskTopology: true,
-			expectErr:          true,
+			parameters: map[string]string{
+				ParameterKeyUseAllowedDiskTopology: "123", // Incorrect type: number.
+			},
+			labels: map[string]string{},
+			expectParams: DiskParameters{
+				DiskType:             "pd-standard",
+				ReplicationType:      "none",
+				DiskEncryptionKMSKey: "",
+				Tags:                 map[string]string{},
+				Labels:               map[string]string{},
+				ResourceTags:         map[string]string{},
+			},
 		},
 		{
 			name:               "useAllowedDiskTopology specified as valid true boolean",