Skip to content

Commit 665558d

Browse files
authored
Merge pull request #2175 from nathanielford/vac-storage-class-api
Move VAC storage API to v1 from v1beta1.
2 parents 7f8afd8 + 45608b0 commit 665558d

File tree

6 files changed

+7
-12
lines changed

6 files changed

+7
-12
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ versions.
3636
| Kubernetes Version | PD CSI Driver Version |
3737
|--------------------|-----------------------|
3838
| HEAD | v1.13.x |
39+
| 1.34 | v1.13.x |
3940
| 1.29 | v1.12.x |
4041
| 1.28 | v1.12.x |
4142
| 1.27 | v1.10.x |

deploy/kubernetes/base/controller/controller.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ spec:
3737
- "--leader-election"
3838
- "--default-fstype=ext4"
3939
- "--controller-publish-readonly=true"
40-
- "--feature-gates=VolumeAttributesClass=true"
4140
env:
4241
- name: PDCSI_NAMESPACE
4342
valueFrom:
@@ -96,7 +95,6 @@ spec:
9695
- "--leader-election"
9796
- "--leader-election-namespace=$(PDCSI_NAMESPACE)"
9897
- "--handle-volume-inuse-error=false"
99-
- "--feature-gates=VolumeAttributesClass=true"
10098
env:
10199
- name: PDCSI_NAMESPACE
102100
valueFrom:

deploy/kubernetes/images/stable-master/image.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ metadata:
44
name: imagetag-csi-provisioner
55
imageTag:
66
name: registry.k8s.io/sig-storage/csi-provisioner
7-
newTag: "v5.2.0"
7+
newTag: "v6.0.0"
88
---
99
apiVersion: builtin
1010
kind: ImageTagTransformer
@@ -20,7 +20,7 @@ metadata:
2020
name: imagetag-csi-resizer
2121
imageTag:
2222
name: registry.k8s.io/sig-storage/csi-resizer
23-
newTag: "v1.13.2"
23+
newTag: "v2.0.0"
2424
---
2525
apiVersion: builtin
2626
kind: ImageTagTransformer

examples/kubernetes/demo-vol-create.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ parameters:
99
provisioned-throughput-on-create: "150Mi"
1010
volumeBindingMode: WaitForFirstConsumer
1111
---
12-
apiVersion: storage.k8s.io/v1beta1
12+
apiVersion: storage.k8s.io/v1
1313
kind: VolumeAttributesClass
1414
metadata:
1515
name: silver
@@ -18,7 +18,7 @@ parameters:
1818
iops: "3000"
1919
throughput: "150Mi"
2020
---
21-
apiVersion: storage.k8s.io/v1beta1
21+
apiVersion: storage.k8s.io/v1
2222
kind: VolumeAttributesClass
2323
metadata:
2424
name: gold
@@ -56,4 +56,4 @@ spec:
5656
- containerPort: 80
5757
volumeMounts:
5858
- mountPath: "/vol"
59-
name: vol
59+
name: vol

test/k8s-integration/main.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -639,8 +639,6 @@ func generateGCETestSkip(testParams *testParameters) string {
639639
skipString := "\\[Disruptive\\]|\\[Serial\\]"
640640
// Skip mount options test until we fix the invalid mount options for xfs.
641641
skipString = skipString + "|csi-gcepd-sc-xfs.*provisioning.should.provision.storage.with.mount.options"
642-
// Skip VolumeAttributesClass tests while it's a beta feature.
643-
skipString = skipString + "|\\[Feature:VolumeAttributesClass\\]"
644642

645643
v := apimachineryversion.MustParseSemantic(testParams.clusterVersion)
646644

@@ -747,8 +745,6 @@ func generateGKETestSkip(testParams *testParameters) string {
747745

748746
// Skip mount options test until we fix the invalid mount options for xfs.
749747
skipString = skipString + "|csi-gcepd-sc-xfs.*provisioning.should.provision.storage.with.mount.options"
750-
// Skip VolumeAttributesClass tests while it's a beta feature.
751-
skipString = skipString + "|\\[Feature:VolumeAttributesClass\\]"
752748

753749
// Skip rwop test when node version is less than 1.32. Test was added only
754750
// in 1.32 and above, see tags in

test/run-k8s-integration-ci.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ else
124124
fi
125125

126126
if [ "$test_volumeattributesclass" = true ]; then
127-
base_cmd="${base_cmd} --volumeattributesclass-files=hdb-volumeattributesclass.yaml --storageclass-for-vac-file=sc-hdb.yaml --kube-runtime-config=api/all=true"
127+
base_cmd="${base_cmd} --volumeattributesclass-files=hdb-volumeattributesclass.yaml --storageclass-for-vac-file=sc-hdb.yaml"
128128
if [ "$deployment_strategy" = "gce" ]; then
129129
base_cmd="${base_cmd} --kube-feature-gates=VolumeAttributesClass=true"
130130
fi

0 commit comments

Comments
 (0)