feat: add e2e test to validate webhook conversion between versions

Author: wazery

docs/book/src/multiversion-tutorial/testdata/project/test/e2e/e2e_test.go

@@ -319,7 +319,86 @@ var _ = Describe("Manager", Ordered, func() {
 
 		// +kubebuilder:scaffold:e2e-webhooks-checks
 
-		// TODO: Customize the e2e test suite with scenarios specific to your project.
+		It("should validate webhook conversion between v1 and v2 CronJob versions", func() {
+			By("applying the v1 CronJob sample")
+			cmd := exec.Command("kubectl", "apply", "-f", "config/samples/batch_v1_cronjob.yaml", "-n", namespace)
+			_, err := utils.Run(cmd)
+			Expect(err).NotTo(HaveOccurred(), "Failed to apply v1 CronJob sample")
+
+			By("verifying the v1 CronJob was created successfully")
+			Eventually(func(g Gomega) {
+				cmd := exec.Command("kubectl", "get", "cronjob.batch.tutorial.kubebuilder.io", "cronjob-sample", "-n", namespace, "-o", "json")
+				output, err := utils.Run(cmd)
+				g.Expect(err).NotTo(HaveOccurred())
+
+				var cronJobData map[string]interface{}
+				err = json.Unmarshal([]byte(output), &cronJobData)
+				g.Expect(err).NotTo(HaveOccurred())
+
+				// Verify this is a v1 resource with string schedule
+				spec, ok := cronJobData["spec"].(map[string]interface{})
+				g.Expect(ok).To(BeTrue(), "Failed to get spec from CronJob")
+
+				schedule, ok := spec["schedule"].(string)
+				g.Expect(ok).To(BeTrue(), "Schedule should be a string in v1 format")
+				g.Expect(schedule).To(Equal("*/1 * * * *"), "Schedule should match the v1 sample format")
+			}).Should(Succeed())
+
+			By("deleting the v1 CronJob sample")
+			cmd = exec.Command("kubectl", "delete", "-f", "config/samples/batch_v1_cronjob.yaml", "-n", namespace, "--ignore-not-found")
+			_, _ = utils.Run(cmd)
+
+			By("applying the v2 CronJob sample")
+			cmd = exec.Command("kubectl", "apply", "-f", "config/samples/batch_v2_cronjob.yaml", "-n", namespace)
+			_, err = utils.Run(cmd)
+			Expect(err).NotTo(HaveOccurred(), "Failed to apply v2 CronJob sample")
+
+			By("verifying the v2 CronJob was created and converted to hub version")
+			Eventually(func(g Gomega) {
+				cmd := exec.Command("kubectl", "get", "cronjob.batch.tutorial.kubebuilder.io", "cronjob-sample", "-n", namespace, "-o", "json")
+				output, err := utils.Run(cmd)
+				g.Expect(err).NotTo(HaveOccurred())
+
+				var cronJobData map[string]interface{}
+				err = json.Unmarshal([]byte(output), &cronJobData)
+				g.Expect(err).NotTo(HaveOccurred())
+
+				spec, ok := cronJobData["spec"].(map[string]interface{})
+				g.Expect(ok).To(BeTrue(), "Failed to get spec from CronJob")
+
+				// The schedule should be stored as string in the hub version (v1) due to conversion
+				schedule, ok := spec["schedule"].(string)
+				g.Expect(ok).To(BeTrue(), "Schedule should be stored as string due to hub conversion")
+				// The v2 sample has minute: "*/1", which should convert to "*/1 * * * *"
+				g.Expect(schedule).To(Equal("*/1 * * * *"), "Schedule should be converted from v2 structured format to v1 cron format")
+			}).Should(Succeed())
+
+			By("testing conversion by patching the CronJob to trigger webhook conversion")
+			// Apply a patch to trigger conversion webhook calls
+			patchData := `{"metadata":{"labels":{"test":"conversion"}}}`
+			cmd = exec.Command("kubectl", "patch", "cronjob.batch.tutorial.kubebuilder.io", "cronjob-sample", "-n", namespace,
+				"--type", "merge", "-p", patchData)
+			_, err = utils.Run(cmd)
+			Expect(err).NotTo(HaveOccurred(), "Failed to patch CronJob")
+
+			By("verifying conversion webhook was called by checking controller logs")
+			// Check the controller logs for conversion messages
+			Eventually(func(g Gomega) {
+				cmd := exec.Command("kubectl", "logs", controllerPodName, "-n", namespace)
+				logs, err := utils.Run(cmd)
+				g.Expect(err).NotTo(HaveOccurred())
+
+				// Look for conversion log messages that should be present in the conversion functions
+				g.Expect(logs).To(ContainSubstring("ConvertTo: Converting CronJob from Spoke version v2 to Hub version v1"),
+					"Should see v2->v1 conversion in logs")
+				g.Expect(logs).To(ContainSubstring("ConvertFrom: Converting CronJob from Hub version v1 to Spoke version v2"),
+					"Should see v1->v2 conversion in logs")
+			}, 30*time.Second, 2*time.Second).Should(Succeed())
+
+			By("cleaning up the v2 CronJob sample")
+			cmd = exec.Command("kubectl", "delete", "-f", "config/samples/batch_v2_cronjob.yaml", "-n", namespace, "--ignore-not-found")
+			_, _ = utils.Run(cmd) // Use _ for cleanup as it might fail if resources don't exist
+		})
 		// Consider applying sample/CR(s) and check their status and/or verifying
 		// the reconciliation by using the metrics, i.e.:
 		// metricsOutput := getMetricsOutput()