Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building helm dependencies when dealing with local charts #5851

Open
2 tasks done
asafhm opened this issue Jan 21, 2025 · 1 comment
Open
2 tasks done

Allow building helm dependencies when dealing with local charts #5851

asafhm opened this issue Jan 21, 2025 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@asafhm
Copy link

asafhm commented Jan 21, 2025

Eschewed features

  • This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

Grant the option to build a local chart's dependencies before templating it.
I.e. populating its internal charts/ directory with the .tgz files of the charts it depends on, by executing helm dependency build.

If we wish to disable this by default, we could expose this functionality through a new boolean field in the generator (e.g. buildDependencies) and let the user set it to true if they wishes.

Why is this needed?

When working with local charts, it's not uncommon to find yourself in a situation where you must rely on external charts as dependencies.
That will require you to check-in those external charts' .tgz files into your source code under charts/ directory.
That is a bad practice. Working with local charts doesn't mean you have to resort to littering your git commits with binaries just to make kustomize work with helm properly.

Can you accomplish the motivating task without this feature, and if so, how?

An external generator like: https://github.com/mgoltzsche/khelm

What other solutions have you considered?

Anything else we should know?

Although using khelm may help, the problem this issue surfaces doesn't sound too complex to fix.

Feature ownership

  • I am interested in contributing this feature myself! 🎉
@asafhm asafhm added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 21, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants