Skip to content

Fix: fix remote error: tls: internal error #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
+6 −0
Open

Fix: fix remote error: tls: internal error #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e90c23d
fix tls bug
dongjiang1989 Jul 10, 2024
3aecde0
update by codereview
dongjiang1989 Sep 9, 2024
367331f
Merge branch 'kubernetes-sigs:master' into fix-tlsconfig
dongjiang1989 Sep 9, 2024
601521b
update kubelet_client
dongjiang1989 Sep 9, 2024
4b0bb66
fix unittest case
dongjiang1989 Sep 9, 2024
b4d69e1
fix unittest case
dongjiang1989 Sep 9, 2024
3db8410
mistake
dongjiang1989 May 12, 2025
5c78454
Merge branch 'kubernetes-sigs:master' into fix-tlsconfig
dongjiang1989 May 12, 2025
f177167
Merge branch 'kubernetes-sigs:master' into fix-tlsconfig
dongjiang1989 Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/metrics-server/app/options/kubelet_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ func (o KubeletClientOptions) Config(restConfig *rest.Config) *client.KubeletCli
config.Client.TLSClientConfig.Insecure = true
config.Client.TLSClientConfig.CAData = nil
config.Client.TLSClientConfig.CAFile = ""
config.Client.TLSClientConfig.NextProtos = []string{"http/1.1", "h2"}
Copy link
Member

@dgrisonnet dgrisonnet Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should proceed with this change. Kubelet supports http/2 by default, so it would be more efficient to have http/2 over http/1.1 by default.

But if this solves the reported issue, could it be that EKS LB needs to be configured by users to supports http/2?

}
if len(o.KubeletCAFile) > 0 {
config.Client.TLSClientConfig.CAFile = o.KubeletCAFile
Expand Down
5 changes: 5 additions & 0 deletions cmd/metrics-server/app/options/kubelet_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,13 @@ func TestConfig(t *testing.T) {
expectFunc: func() client.KubeletClientConfig {
e := expected
e.Client.Insecure = true
e.Client.KeyFile = "KeyFile"
e.Client.KeyData = []byte("KeyData")
e.Client.CAFile = ""
e.Client.CAData = nil
e.Client.CertFile = "CertFile"
e.Client.CertData = []byte("CertData")
e.Client.NextProtos = []string{"http/1.1", "h2"}
return e
},
},
Expand Down