Skip to content

Commit a55eefc

Browse files
authored
Merge pull request #5225 from natasha41575/pod-gen-mirror
KEP-5067: correct details about mirror pod implementation
2 parents 22a44f1 + 46dd128 commit a55eefc

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

keps/sig-node/5067-pod-generation/README.md

+6-14
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ and make progress.
231231
-->
232232

233233
* Expand the set of mutable fields.
234-
* Populate `metadata.generation` and `status.ObservedGeneration` on mirror pods.
235234

236235
## Proposal
237236

@@ -458,19 +457,12 @@ regressions back to decreasing values.
458457

459458
#### Mirror pods
460459

461-
We will consider populating `metadata.generation` and `status.observedGeneration` out of scope for mirror
462-
pods. This means:
463-
464-
* The API server never sets `metadata.generation` for mirror pods.
465-
* If there is `metadata.generation` or `status.observedGeneration` set in the incoming config for a static pod, we ignore and drop them on the API side.
466-
* Kubelet never sets `status.observedGeneration` for mirror pods (it will need to explicitly exclude them).
467-
468-
This is because the kubelet currently computes the internal pod UID of a mirror pod
469-
using a hash of the podspec, meaning that any update to the podspec results in the kubelet
470-
seeing it as a pod deletion followed by creation of a new pod. This defeats the
471-
purpose of generation tracking, since the generation of a mirror pod will always
472-
be 1. To fully support generation for mirror pods, more changes to the kubelet's
473-
logic will be expected.
460+
The kubelet currently computes the internal pod UID of a mirror pod using a hash of the podspec,
461+
meaning that any update to the podspec results in the kubelet seeing it as a pod deletion followed
462+
by creation of a new pod. To fully support generation for mirror pods more changes to the kubelet's logic
463+
will be expected. For now, we will not treat mirror pods in any special way. This means that due
464+
to the way that mirror pods are implemented, the generation (and observedGeneration) of a mirror pod
465+
will always be 1.
474466

475467
#### Future enhancements
476468

0 commit comments

Comments
 (0)