Skip to content

Commit 6f0114d

Browse files
committed
Test: fix X-Original-Forwarded-Host case
Signed-off-by: Clément Nussbaumer <[email protected]>
1 parent fe80fe8 commit 6f0114d

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

test/e2e/settings/enable_real_ip.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ var _ = framework.DescribeSetting("enable-real-ip", func() {
6565
Body().
6666
Raw()
6767

68-
assert.NotContains(ginkgo.GinkgoT(), body, "host=myhost")
68+
assert.NotRegexp(ginkgo.GinkgoT(), `(\s)host=myhost`, body)
6969
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-host=myhost")
7070
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-proto=myproto")
7171
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-port=1234")
@@ -105,7 +105,8 @@ var _ = framework.DescribeSetting("enable-real-ip", func() {
105105
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-port=80")
106106
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-proto=http")
107107
assert.Contains(ginkgo.GinkgoT(), body, "x-original-forwarded-for=1.2.3.4")
108-
assert.NotContains(ginkgo.GinkgoT(), body, "host=myhost")
108+
assert.Contains(ginkgo.GinkgoT(), body, "x-original-forwarded-host=myhost")
109+
assert.NotRegexp(ginkgo.GinkgoT(), `(\s)host=myhost`, body)
109110
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-host=myhost")
110111
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-proto=myproto")
111112
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-port=1234")

test/e2e/settings/forwarded_headers.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ var _ = framework.DescribeSetting("use-forwarded-headers", func() {
6666
Body().
6767
Raw()
6868

69-
assert.Contains(ginkgo.GinkgoT(), body, "host=myhost")
69+
assert.Regexp(ginkgo.GinkgoT(), `(\s)host=myhost`, body)
7070
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-host=myhost")
7171
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-proto=myproto")
7272
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-scheme=myproto")
@@ -86,7 +86,7 @@ var _ = framework.DescribeSetting("use-forwarded-headers", func() {
8686
Body().
8787
Raw()
8888

89-
assert.Contains(ginkgo.GinkgoT(), body, "host=myhost.com")
89+
assert.Regexp(ginkgo.GinkgoT(), `(\s)host=myhost`, body)
9090
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-host=myhost.com")
9191
})
9292

@@ -122,7 +122,7 @@ var _ = framework.DescribeSetting("use-forwarded-headers", func() {
122122
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-scheme=http")
123123
assert.Contains(ginkgo.GinkgoT(), body, "x-original-forwarded-for=1.2.3.4")
124124
assert.Contains(ginkgo.GinkgoT(), body, "x-original-forwarded-host=myhost")
125-
assert.NotContains(ginkgo.GinkgoT(), body, "host=myhost")
125+
assert.NotRegexp(ginkgo.GinkgoT(), `(\s)host=myhost`, body)
126126
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-host=myhost")
127127
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-proto=myproto")
128128
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-scheme=myproto")

0 commit comments

Comments
 (0)