Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize config file paths #12911

Closed
emmanuel opened this issue Feb 28, 2025 · 3 comments · May be fixed by #12912
Closed

Parameterize config file paths #12911

emmanuel opened this issue Feb 28, 2025 · 3 comments · May be fixed by #12912
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@emmanuel
Copy link

In order to run the controller in our environment, I need to run with readOnlyRootFilesystem: true. I know that's not officially supported (#9504). I'm not asking for support for that, I'm asking for the currently-hardcoded config file paths to take an env var if present, and use the current paths as the defaults if no env var is present.

The controller currently writes to hard-coded paths in the /etc directory: /etc/nginx/nginx.conf and /etc/nginx/lua/cfg.json. Because those directories also contain other files from the container filesystem, the combination makes it impossible to place the config file on an empty dir without significant effort.

I didn't see one, aside from the issue linked above, which is different.

Not related to a particular Kubernetes version.
@emmanuel emmanuel added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 28, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 28, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

emmanuel added a commit to pelotech/ingress-nginx that referenced this issue Feb 28, 2025
@emmanuel
feat: Parameterize config paths. Fixes kubernetes#12911.
b164870
@emmanuel emmanuel mentioned this issue Feb 28, 2025
Open
10 tasks
@Gacko
Copy link
Member

Gacko commented Mar 1, 2025

I think this is not the only thing blocking you from running Ingress NGINX with readOnlyRootFilesystem: true. IIRC NGINX itself also requires writeable directories and I do not know if you can just mount volumes in all of these locations.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2025

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 1, 2025
@Gacko Gacko closed this as completed Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
[SIG Network] Ingress NGINX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Parameterize config paths. Fixes #12911. pelotech/ingress-nginx
3 participants
@emmanuel @Gacko @k8s-ci-robot