Skip to content

cors-allow-origin annotation bad docs #13189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mikhail-93 opened this issue Apr 10, 2025 · 3 comments
Closed

cors-allow-origin annotation bad docs #13189

Mikhail-93 opened this issue Apr 10, 2025 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@Mikhail-93
Copy link

Config from example in docs smells bad:
In your example(its not working):
nginx.ingress.kubernetes.io/cors-allow-origin: "https://origin-site.com:4443, http://origin-site.com, myprotocol://example.org:1199"

Working option:
nginx.ingress.kubernetes.io/cors-allow-origin: https://origin-site.com:4443 http://origin-site.com myprotocol://example.org:1199

@Mikhail-93 Mikhail-93 added the kind/bug Categorizes issue or PR as related to a bug. label Apr 10, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 10, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@longwuyuan
Copy link
Contributor

cc @elizabeth-dev

@Gacko
Copy link
Member

Gacko commented Apr 23, 2025

We have a PR open for this, we just didn't manage to review and merge it, yet, as it also requires adding the NJS module. However, this is a duplicate of #10267, so I'm going to close this issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

4 participants