Improve the node package list updates

Signed-off-by: Ciprian Hacman <[email protected]>

Author: hakman

upup/pkg/fi/nodeup/nodetasks/package.go

@@ -331,20 +331,19 @@ func (_ *Package) RenderLocal(t *local.LocalTarget, a, e, changes *Package) erro
 			// To avoid unnecessary apt-get update calls, we check the timestamp of this file.
 			// If it is newer than 10 minutes, we skip apt-get update.
 			stat, err := os.Stat("/var/lib/dpkg/status")
-			if err != nil {
-				klog.Infof("Error getting dpkg status info: %v", err)
+			if err == nil && stat.ModTime().After(time.Now().Add(-10*time.Minute)) {
+				klog.V(2).Infof("Skipping fetching the list of available packages")
 			} else {
-				if stat.ModTime().After(time.Now().Add(-10 * time.Minute)) {
-					klog.Infof("Skipping package install as /var/lib/dpkg/status is newer than 10 minutes")
-				} else {
-					args := []string{"apt-get", "update"}
-					klog.Infof("Running command %s", args)
-					cmd := exec.Command(args[0], args[1:]...)
-					cmd.Env = env
-					output, err := cmd.CombinedOutput()
-					if err != nil {
-						klog.Infof("Error fetching the latest list of available packages: %v:\n%s", err, string(output))
-					}
+				if err != nil && !os.IsNotExist(err) {
+					klog.Warningf("Error getting dpkg status info: %v", err)
+				}
+				args := []string{"apt-get", "update"}
+				klog.Infof("Running command %s", args)
+				cmd := exec.Command(args[0], args[1:]...)
+				cmd.Env = env
+				output, err := cmd.CombinedOutput()
+				if err != nil {
+					return fmt.Errorf("error fetching the list of available packages: %v:\n%s", err, string(output))
 				}
 			}
 		}