Fix lint issues in the imported drivers

Note: we can't change exported errors

Since they are used in "known issues"

Author: afbjorklund

pkg/drivers/hyperv/hyperv.go

@@ -25,6 +25,8 @@ import (
 	"strings"
 	"time"
 
+	"github.com/pkg/errors"
+
 	"github.com/docker/machine/libmachine/drivers"
 	"github.com/docker/machine/libmachine/log"
 	"github.com/docker/machine/libmachine/mcnflag"
@@ -159,7 +161,7 @@ func (d *Driver) GetURL() (string, error) {
 func (d *Driver) GetState() (state.State, error) {
 	stdout, err := cmdOut("(", "Hyper-V\\Get-VM", d.MachineName, ").state")
 	if err != nil {
-		return state.None, fmt.Errorf("Failed to find the VM status")
+		return state.None, errors.New("Failed to find the VM status")
 	}
 
 	resp := parseLines(stdout)
@@ -320,11 +322,11 @@ func (d *Driver) chooseVirtualSwitch() (string, error) {
 		// prefer Default Switch over external switches
 		switches, err := getHyperVSwitches([]string{fmt.Sprintf("Where-Object {($_.SwitchType -eq 'External') -or ($_.Id -eq '%s')}", defaultSwitchID), "Sort-Object -Property SwitchType"})
 		if err != nil {
-			return "", fmt.Errorf("unable to get available hyperv switches")
+			return "", errors.New("unable to get available hyperv switches")
 		}
 
 		if len(switches) < 1 {
-			return "", fmt.Errorf("no External vswitch nor Default Switch found. A valid vswitch must be available for this command to run. Check https://docs.docker.com/machine/drivers/hyper-v/")
+			return "", errors.New("no External vswitch nor Default Switch found. A valid vswitch must be available for this command to run. Check https://docs.docker.com/machine/drivers/hyper-v/")
 		}
 
 		return switches[0].Name, nil
@@ -333,7 +335,7 @@ func (d *Driver) chooseVirtualSwitch() (string, error) {
 	// prefer external switches (using descending order)
 	switches, err := getHyperVSwitches([]string{fmt.Sprintf("Where-Object {$_.Name -eq '%s'}", d.VSwitch), "Sort-Object -Property SwitchType -Descending"})
 	if err != nil {
-		return "", fmt.Errorf("unable to get available hyperv switches")
+		return "", errors.New("unable to get available hyperv switches")
 	}
 
 	if len(switches) < 1 {
@@ -460,7 +462,7 @@ func (d *Driver) GetIP() (string, error) {
 
 	resp := parseLines(stdout)
 	if len(resp) < 1 {
-		return "", fmt.Errorf("IP not found")
+		return "", errors.New("IP not found")
 	}
 
 	return resp[0], nil

pkg/drivers/hyperv/powershell.go

@@ -30,6 +30,7 @@ import (
 
 var powershell string
 
+//nolint:staticcheck // ST1005: error strings should not be capitalized
 var (
 	ErrPowerShellNotFound = errors.New("Powershell was not found in the path")
 	ErrNotAdministrator   = errors.New("Hyper-v commands have to be run as an Administrator")

pkg/drivers/virtualbox/disk.go

@@ -145,6 +145,7 @@ func getVMDiskInfo(name string, vbox VBoxManager) (*VirtualDisk, error) {
 			disk.Path = val
 		case "SATA-ImageUUID-1-0":
 			disk.UUID = val
+		default:
 		}
 
 		return nil

pkg/drivers/virtualbox/network.go

@@ -34,9 +34,12 @@ const (
 	dhcpPrefix   = "HostInterfaceNetworking-"
 )
 
+//nolint:staticcheck // ST1005: error strings should not be capitalized
 var (
-	reHostOnlyAdapterCreated        = regexp.MustCompile(`Interface '(.+)' was successfully created`)
-	errNewHostOnlyAdapterNotVisible = errors.New("The host-only adapter we just created is not visible. This is a well known VirtualBox bug. You might want to uninstall it and reinstall at least version 5.0.12 that is is supposed to fix this issue")
+	reHostOnlyAdapterCreated         = regexp.MustCompile(`Interface '(.+)' was successfully created`)
+	errNewHostOnlyAdapterNotVisible  = errors.New("The host-only adapter we just created is not visible. This is a well known VirtualBox bug. You might want to uninstall it and reinstall at least version 5.0.12 that is is supposed to fix this issue")
+	errFailedToCreateHostOnlyAdapter = errors.New("Failed to create host-only adapter")
+	errFailedToFindHostOnlyAdapter   = errors.New("Failed to find a new host-only adapter")
 )
 
 // Host-only network.
@@ -113,7 +116,7 @@ func createHostonlyAdapter(vbox VBoxManager) (*hostOnlyNetwork, error) {
 
 	res := reHostOnlyAdapterCreated.FindStringSubmatch(out)
 	if res == nil {
-		return nil, errors.New("Failed to create host-only adapter")
+		return nil, errFailedToCreateHostOnlyAdapter
 	}
 
 	return &hostOnlyNetwork{Name: res[1]}, nil
@@ -168,6 +171,7 @@ func listHostOnlyAdapters(vbox VBoxManager) (map[string]*hostOnlyNetwork, error)
 			}
 
 			n = &hostOnlyNetwork{}
+		default:
 		}
 
 		return nil
@@ -245,7 +249,7 @@ func waitForNewHostOnlyNetwork(oldNets map[string]*hostOnlyNetwork, vbox VBoxMan
 		}
 	}
 
-	return nil, errors.New("Failed to find a new host-only adapter")
+	return nil, errFailedToFindHostOnlyAdapter
 }
 
 // DHCP server info.
@@ -354,6 +358,7 @@ func listDHCPServers(vbox VBoxManager) (map[string]*dhcpServer, error) {
 			dhcp.IPv4.Mask = parseIPv4Mask(val)
 		case "Enabled":
 			dhcp.Enabled = (val == "Yes")
+		default:
 		}
 
 		return nil

pkg/drivers/virtualbox/vbm.go

@@ -127,6 +127,7 @@ func (v *VBoxCmdManager) vbmOutErrRetry(retry int, args ...string) (string, stri
 func checkVBoxManageVersion(version string) error {
 	major, minor, err := parseVersion(version)
 	if (err != nil) || (major < 4) || (major == 4 && minor <= 2) {
+		//nolint:staticcheck // ST1005: error strings should not be capitalized
 		return fmt.Errorf("We support Virtualbox starting with version 5. Your VirtualBox install is %q. Please upgrade at https://www.virtualbox.org", version)
 	}
 
@@ -140,17 +141,17 @@ func checkVBoxManageVersion(version string) error {
 func parseVersion(version string) (int, int, error) {
 	parts := strings.Split(version, ".")
 	if len(parts) < 2 {
-		return 0, 0, fmt.Errorf("Invalid version: %q", version)
+		return 0, 0, fmt.Errorf("invalid version: %q", version)
 	}
 
 	major, err := strconv.Atoi(parts[0])
 	if err != nil {
-		return 0, 0, fmt.Errorf("Invalid version: %q", version)
+		return 0, 0, fmt.Errorf("invalid version: %q", version)
 	}
 
 	minor, err := strconv.Atoi(parts[1])
 	if err != nil {
-		return 0, 0, fmt.Errorf("Invalid version: %q", version)
+		return 0, 0, fmt.Errorf("invalid version: %q", version)
 	}
 
 	return major, minor, err

pkg/drivers/virtualbox/virtualbox.go

@@ -52,6 +52,7 @@ const (
 	defaultHostLoopbackReachable = true
 )
 
+//nolint:staticcheck // ST1005: error strings should not be capitalized
 var (
 	ErrUnableToGenerateRandomIP = errors.New("unable to generate random IP")
 	ErrMustEnableVTX            = errors.New("This computer doesn't have VT-X/AMD-v enabled. Enabling it in the BIOS is mandatory")
@@ -578,6 +579,7 @@ func (d *Driver) Start() error {
 		log.Infof("Check network to re-create if needed...")
 
 		if hostOnlyAdapter, err = d.setupHostOnlyNetwork(d.MachineName); err != nil {
+			//nolint:staticcheck // ST1005: error strings should not be capitalized
 			return fmt.Errorf("Error setting up host only network on machine start: %s", err)
 		}
 	}
@@ -591,8 +593,10 @@ func (d *Driver) Start() error {
 
 		if err := d.vbm("startvm", d.MachineName, "--type", d.UIType); err != nil {
 			if lines, readErr := d.readVBoxLog(); readErr == nil && len(lines) > 0 {
+				//nolint:staticcheck // ST1005: error strings should not be capitalized
 				return fmt.Errorf("Unable to start the VM: %s\nDetails: %s", err, lines[len(lines)-1])
 			}
+			//nolint:staticcheck // ST1005: error strings should not be capitalized
 			return fmt.Errorf("Unable to start the VM: %s", err)
 		}
 	case state.Paused:
@@ -608,6 +612,7 @@ func (d *Driver) Start() error {
 		// Verify that VT-X is not disabled in the started VM
 		vtxIsDisabled, err := d.IsVTXDisabledInTheVM()
 		if err != nil {
+			//nolint:staticcheck // ST1005: error strings should not be capitalized
 			return fmt.Errorf("Checking if hardware virtualization is enabled failed: %s", err)
 		}
 
@@ -666,6 +671,7 @@ func (d *Driver) Start() error {
 	d.sleeper.Sleep(5 * time.Second)
 
 	if err := d.vbm("startvm", d.MachineName, "--type", d.UIType); err != nil {
+		//nolint:staticcheck // ST1005: error strings should not be capitalized
 		return fmt.Errorf("Unable to start the VM: %s", err)
 	}
 
@@ -709,10 +715,12 @@ func (d *Driver) Stop() error {
 // Restart restarts a machine which is known to be running.
 func (d *Driver) Restart() error {
 	if err := d.Stop(); err != nil {
+		//nolint:staticcheck // ST1005: error strings should not be capitalized
 		return fmt.Errorf("Problem stopping the VM: %s", err)
 	}
 
 	if err := d.Start(); err != nil {
+		//nolint:staticcheck // ST1005: error strings should not be capitalized
 		return fmt.Errorf("Problem starting the VM: %s", err)
 	}
 
@@ -786,6 +794,7 @@ func (d *Driver) getHostOnlyMACAddress() (string, error) {
 	re := regexp.MustCompile(`(?m)^hostonlyadapter([\d]+)`)
 	groups := re.FindStringSubmatch(stdout)
 	if len(groups) < 2 {
+		//nolint:staticcheck // ST1005: error strings should not be capitalized
 		return "", errors.New("Machine does not have a host-only adapter")
 	}
 
@@ -794,6 +803,7 @@ func (d *Driver) getHostOnlyMACAddress() (string, error) {
 	re = regexp.MustCompile(fmt.Sprintf("(?m)^macaddress%s=\"(.*)\"", adapterNumber))
 	groups = re.FindStringSubmatch(stdout)
 	if len(groups) < 2 {
+		//nolint:staticcheck // ST1005: error strings should not be capitalized
 		return "", fmt.Errorf("Could not find MAC address for adapter %v", adapterNumber)
 	}
 
@@ -831,6 +841,7 @@ func (d *Driver) parseIPForMACFromIPAddr(ipAddrOutput string, macAddress string)
 		}
 	}
 
+	//nolint:staticcheck // ST1005: error strings should not be capitalized
 	return "", fmt.Errorf("Could not find matching IP for MAC address %v", macAddress)
 }
 
@@ -1023,7 +1034,7 @@ func getAvailableTCPPort(port int) (int, error) {
 		port = 0 // Throw away the port hint before trying again
 		time.Sleep(1 * time.Second)
 	}
-	return 0, fmt.Errorf("unable to allocate tcp port")
+	return 0, errors.New("unable to allocate tcp port")
 }
 
 // Setup a NAT port forwarding entry.

pkg/drivers/virtualbox/vm.go

@@ -45,6 +45,7 @@ func getVMInfo(name string, vbox VBoxManager) (*VM, error) {
 				return err
 			}
 			vm.Memory = v
+		default:
 		}
 
 		return nil