Skip to content

Commit a7fadf6

Browse files
authored
Merge pull request #56 from pacoxu/fix-option-cgroups
add back cgroup hugetlb optional check
2 parents ce18350 + cd9f6de commit a7fadf6

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

validators/types.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,12 @@ type KernelSpec struct {
5252
RequiredCgroupsV1 []KernelConfig `json:"requiredCgroupsV1,omitempty"`
5353
// RequiredCgroupsV2 contains all kernel configurations required to be enabled for cgroups v2.
5454
RequiredCgroupsV2 []KernelConfig `json:"requiredCgroupsV2,omitempty"`
55-
// Optional contains all kernel configurations are required for optional
56-
// features.
55+
// Optional contains optional kernel configurations.
5756
Optional []KernelConfig `json:"optional,omitempty"`
57+
// OptionalCgroupsV1 contains optional kernel configurations related to cgroups v1.
58+
OptionalCgroupsV1 []KernelConfig `json:"optionalCgroupsV1,omitempty"`
59+
// OptionalCgroupsV2 contains optional kernel configurations related to cgroups v2.
60+
OptionalCgroupsV2 []KernelConfig `json:"optionalCgroupsV2,omitempty"`
5861
// Forbidden contains all kernel configurations which areforbidden (disabled
5962
// or not set)
6063
Forbidden []KernelConfig `json:"forbidden,omitempty"`

validators/types_unix.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,12 @@ var DefaultSysSpec = SysSpec{
7272
{Name: "SECCOMP", Description: "Required for seccomp."},
7373
{Name: "SECCOMP_FILTER", Description: "Required for seccomp mode 2."},
7474
},
75+
OptionalCgroupsV1: []KernelConfig{
76+
{Name: "CGROUP_HUGETLB", Description: "Required for hugetlb cgroup."},
77+
},
78+
OptionalCgroupsV2: []KernelConfig{
79+
{Name: "CGROUP_HUGETLB", Description: "Required for hugetlb cgroup."},
80+
},
7581
Forbidden: []KernelConfig{},
7682
},
7783
Cgroups: []string{"cpu", "cpuacct", "cpuset", "devices", "freezer", "memory", "pids"},

0 commit comments

Comments
 (0)