fixes #355

Author: Shreya2005-2005

pkg/registry/softwarecomposition/openvulnerabilityexchange/strategy.go

@@ -59,8 +59,16 @@ func (OpenVulnerabilityExchangeContainerStrategy) PrepareForCreate(_ context.Con
 func (OpenVulnerabilityExchangeContainerStrategy) PrepareForUpdate(_ context.Context, _, _ runtime.Object) {
 }
 
-func (OpenVulnerabilityExchangeContainerStrategy) Validate(_ context.Context, _ runtime.Object) field.ErrorList {
-	return field.ErrorList{}
+func (OpenVulnerabilityExchangeContainerStrategy) Validate(_ context.Context, obj runtime.Object) field.ErrorList {
+	vexContainer := obj.(*softwarecomposition.OpenVulnerabilityExchangeContainer)
+	var allErrors field.ErrorList
+	if vexContainer.Spec.Author == "" {
+		allErrors = append(allErrors, field.Required(field.NewPath("spec", "author"), "must not be empty"))
+	}
+	if len(vexContainer.Spec.Statements) == 0 {
+		allErrors = append(allErrors, field.Required(field.NewPath("spec", "statements"), "must contain at least one statement"))
+	}
+	return allErrors
 }
 
 // WarningsOnCreate returns warnings for the creation of the given object.

pkg/registry/softwarecomposition/openvulnerabilityexchange/strategy_test.go

@@ -0,0 +1,76 @@
+package openvulnerabilityexchange
+
+import (
+	"context"
+	"testing"
+
+	"github.com/kubescape/storage/pkg/apis/softwarecomposition"
+)
+
+func TestValidate_RequiresAuthorAndStatements(t *testing.T) {
+	cases := []struct {
+		name      string
+		obj       *softwarecomposition.OpenVulnerabilityExchangeContainer
+		wantPaths map[string]int
+	}{
+		{
+			name: "empty spec is rejected on both fields",
+			obj:  &softwarecomposition.OpenVulnerabilityExchangeContainer{},
+			wantPaths: map[string]int{
+				"spec.author":     1,
+				"spec.statements": 1,
+			},
+		},
+		{
+			name: "missing statements only",
+			obj: &softwarecomposition.OpenVulnerabilityExchangeContainer{
+				Spec: softwarecomposition.VEX{
+					Metadata: softwarecomposition.Metadata{Author: "kubescape.io"},
+				},
+			},
+			wantPaths: map[string]int{
+				"spec.statements": 1,
+			},
+		},
+		{
+			name: "missing author only",
+			obj: &softwarecomposition.OpenVulnerabilityExchangeContainer{
+				Spec: softwarecomposition.VEX{
+					Statements: []softwarecomposition.Statement{{}},
+				},
+			},
+			wantPaths: map[string]int{
+				"spec.author": 1,
+			},
+		},
+		{
+			name: "valid spec has no errors",
+			obj: &softwarecomposition.OpenVulnerabilityExchangeContainer{
+				Spec: softwarecomposition.VEX{
+					Metadata:   softwarecomposition.Metadata{Author: "kubescape.io"},
+					Statements: []softwarecomposition.Statement{{}},
+				},
+			},
+			wantPaths: map[string]int{},
+		},
+	}
+
+	s := OpenVulnerabilityExchangeContainerStrategy{}
+	for _, tt := range cases {
+		t.Run(tt.name, func(t *testing.T) {
+			errs := s.Validate(context.TODO(), tt.obj)
+			got := map[string]int{}
+			for _, e := range errs {
+				got[e.Field]++
+			}
+			if len(got) != len(tt.wantPaths) {
+				t.Fatalf("got paths %v, want %v", got, tt.wantPaths)
+			}
+			for path, count := range tt.wantPaths {
+				if got[path] != count {
+					t.Errorf("path %s: got %d errors, want %d", path, got[path], count)
+				}
+			}
+		})
+	}
+}