Skip to content

Commit 0bd8a42

Browse files
committed
self-review
1 parent 9e082e0 commit 0bd8a42

File tree

3 files changed

+20
-14
lines changed

3 files changed

+20
-14
lines changed

documentation/modules/storage-support.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ If the {virt} storage does not support {ocp-doc}/storage/dynamic-provisioning#dy
6969
+
7070
`ReadWriteOnce` access mode does not support live virtual machine migration.
7171
72-
// See link:https://access.redhat.com/documentation/en-us/openshift_container_platform/{ocp-version}/html/virtualization/virtual-machines#virt-customizing-storage-profile_virt-creating-data-volumes[Enabling a statically-provisioned storage class] for details on editing the storage profile.
72+
See link:https://access.redhat.com/documentation/en-us/openshift_container_platform/{ocp-version}/html/virtualization/virtual-machines#virt-customizing-storage-profile_virt-creating-data-volumes[Enabling a statically-provisioned storage class] for details on editing the storage profile.
7373
====
7474

7575
[NOTE]

documentation/modules/vddk-validator-containers.adoc

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,41 +4,47 @@
44

55
:_content-type: REFERENCE
66
[id="vddk-validator-containers_{context}"]
7-
= VDDK validator containers need requests and limits
7+
= Requests and limits for VDDK validator containers
88

9-
If you have the cluster or project resource quotas set, you must ensure that you have a sufficient quota for the {project-short} pods to perform the migration. 
9+
When you set cluster or project resource quotas, be sure that you have a sufficient quota for the {project-short} pods to perform the migration. 
1010

11-
// For more information, see {ocp-doc}/building_applications/index#quotas-creating-a-quota_quotas-setting-per-project
11+
For more information on creating, setting, and viewing quotas, see {ocp-doc}/building_applications/index#quotas[Quotas]
1212

13-
You can see the defaults, which you can override in the ForkliftController custom resource (CR), listed as follows. If necessary, you can adjust these defaults
13+
The defaults that are related to VDDK validator containers are listed as follows. You can override these defaults in the `ForkliftController` custom resource (CR).
1414

15-
These settings are highly dependent on your environment. If there are many migrations happening at once and the quotas are not set enough for the migrations, then the migrations can fail. This can also be correlated to the `MAX_VM_INFLIGHT` setting that determines how many VMs/disks are migrated at once.
1615

17-
.Defaults which can be overriden in the ForkliftController CR:
16+
[NOTE]
17+
====
18+
These settings are highly dependent on your environment. If there are many migrations happening at once and the quotas are not set high enough for the migrations, then the migrations can fail.
19+
20+
Migration success or failure is also connected to the `MAX_VM_INFLIGHT` setting that determines how many VMs or disks are migrated at once.
21+
====
22+
23+
[id="defaults-that-can-be-overridden-in-forklift-controller_{context}"]
24+
== Defaults that can be overridden in the ForkliftController CR:
1825

19-
* This affects both cold and warm migrations:
26+
* These defaults affect both cold and warm migrations:
2027
+
21-
For cold migration, it is likely to be more resource intensive as it performs the disk copy. For warm migration, you could potentially reduce the requests.
28+
Cold migration is likely to be more resource intensive because it copies the disks. For warm migration, you could potentially reduce the requests.
2229

2330
** virt_v2v_container_limits_cpu: `4000m`
2431
** virt_v2v_container_limits_memory: `8Gi`
2532
** virt_v2v_container_requests_cpu: `1000m`
2633
** virt_v2v_container_requests_memory: `1Gi`
2734
+
28-
2935
[NOTE]
3036
====
3137
Cold and warm migration using `virt-v2v` can be resource-intensive. For more details, see link:https://libguestfs.org/virt-v2v.1.html#compute-power-and-ram[Compute power and RAM].
3238
====
3339

40+
* These defaults affect all migrations with hooks:
3441

35-
* This affects any migrations with hooks:
3642
** hooks_container_limits_cpu: `1000m`
3743
** hooks_container_limits_memory: `1Gi`
3844
** hooks_container_requests_cpu: `100m`
3945
** hooks_container_requests_memory: `150Mi`
4046

41-
* This affects any OVA migrations:
47+
* TThese defaults affect all Open Virtual Appliance (OVA) file migrations: migrations:
4248

4349
** ova_container_limits_cpu: `1000m`
4450
** ova_container_limits_memory: `1Gi`

documentation/modules/virt-migration-workflow.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ The workflow describes the following steps:
2525
+
2626
*For each VM disk:*
2727

28-
. The `Containerized Data Importer (CDI) Controller` service creates a persistent volume claim (PVC) based on the parameters specified in the `DataVolume` CR.


28+
. The `Containerized Data Importer (CDI) Controller` service creates a persistent volume claim (PVC) based on the parameters specified in the `DataVolume` CR.
2929
. If the `StorageClass` has a dynamic provisioner, the persistent volume (PV) is dynamically provisioned by the `StorageClass` provisioner.
3030
. The `CDI Controller` service creates an `importer` pod.
3131
. The `importer` pod streams the VM disk to the PV.
@@ -67,7 +67,7 @@ The `virt-launcher` pod runs `QEMU-KVM` with the PVCs attached as VM disks.
6767
+
6868
*For each VM disk:*
6969

70-
. The `Containerized Data Importer (CDI) Controller` service creates a blank persistent volume claim (PVC) based on the parameters specified in the `DataVolume` CR.


70+
. The `Containerized Data Importer (CDI) Controller` service creates a blank persistent volume claim (PVC) based on the parameters specified in the `DataVolume` CR.
7171
. If the `StorageClass` has a dynamic provisioner, the persistent volume (PV) is dynamically provisioned by the `StorageClass` provisioner.
7272

7373
*For all VM disks:*

0 commit comments

Comments
 (0)