Skip to content

Commit 8601f66

Browse files
authored
Merge pull request #313 from loheagn/fix_BaseConfigurationSpec
Remove `spec.BaseConfigurationSpec` from `configuration_controller_test.go`
2 parents 16bd07e + db94a32 commit 8601f66

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

controllers/configuration_controller_test.go

+9-14
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@ import (
55
"encoding/base64"
66
"encoding/json"
77
"fmt"
8-
"k8s.io/utils/pointer"
98
"os"
109
"reflect"
1110
"strings"
1211
"testing"
1312
"time"
1413

14+
"k8s.io/utils/pointer"
15+
1516
"github.com/agiledragon/gomonkey/v2"
1617
"github.com/aliyun/alibaba-cloud-sdk-go/services/sts"
1718
"github.com/stretchr/testify/assert"
@@ -124,7 +125,7 @@ func TestInitTFConfigurationMetaWithDeleteResource(t *testing.T) {
124125
req.Namespace = "default"
125126
req.Name = "abc"
126127
testcases := []struct {
127-
name string
128+
name string
128129
configuration v1beta2.Configuration
129130
meta *TFConfigurationMeta
130131
}{
@@ -135,13 +136,11 @@ func TestInitTFConfigurationMetaWithDeleteResource(t *testing.T) {
135136
Name: "abc",
136137
},
137138
Spec: v1beta2.ConfigurationSpec{
138-
BaseConfigurationSpec: v1beta2.BaseConfigurationSpec{
139-
DeleteResource: pointer.Bool(true),
140-
},
139+
DeleteResource: pointer.Bool(true),
141140
},
142141
},
143142
meta: &TFConfigurationMeta{
144-
DeleteResource: true,
143+
DeleteResource: true,
145144
},
146145
},
147146
{
@@ -151,13 +150,11 @@ func TestInitTFConfigurationMetaWithDeleteResource(t *testing.T) {
151150
Name: "abc",
152151
},
153152
Spec: v1beta2.ConfigurationSpec{
154-
BaseConfigurationSpec: v1beta2.BaseConfigurationSpec{
155-
DeleteResource: pointer.Bool(false),
156-
},
153+
DeleteResource: pointer.Bool(false),
157154
},
158155
},
159156
meta: &TFConfigurationMeta{
160-
DeleteResource: false,
157+
DeleteResource: false,
161158
},
162159
},
163160
{
@@ -167,13 +164,11 @@ func TestInitTFConfigurationMetaWithDeleteResource(t *testing.T) {
167164
Name: "abc",
168165
},
169166
Spec: v1beta2.ConfigurationSpec{
170-
BaseConfigurationSpec: v1beta2.BaseConfigurationSpec{
171-
DeleteResource: nil,
172-
},
167+
DeleteResource: nil,
173168
},
174169
},
175170
meta: &TFConfigurationMeta{
176-
DeleteResource: true,
171+
DeleteResource: true,
177172
},
178173
},
179174
}

0 commit comments

Comments
 (0)