Clean code

Author: kvyaceslav

app/Constants/AuthConstants.php

@@ -4,10 +4,10 @@
 
 class AuthConstants
 {
-    const VALIDATION = 'Email or Password wrong.';
-    const UNAUTHORIZED = 'Unauthorized.';
-    const REGISTER = 'User register successfully.';
-    const LOGIN = 'User Login successfully.';
-    const LOGOUT = 'User Logout successfully.';
-    const PERMISSION = 'You don`t have permission.';
+    public const VALIDATION = 'Email or Password wrong.';
+    public const UNAUTHORIZED = 'Unauthorized.';
+    public const REGISTER = 'User register successfully.';
+    public const LOGIN = 'User Login successfully.';
+    public const LOGOUT = 'User Logout successfully.';
+    public const PERMISSION = 'You don`t have permission.';
 }

app/Constants/CategoryConstants.php

@@ -4,7 +4,7 @@
 
 class CategoryConstants
 {
-    const DESTROY = 'Category removed successfully.';
-    const STORE = 'Category created successfully.';
-    const UPDATE = 'Category updated successfully.';
+    public const DESTROY = 'Category removed successfully.';
+    public const STORE = 'Category created successfully.';
+    public const UPDATE = 'Category updated successfully.';
 }

app/Constants/ProductConstants.php

@@ -4,7 +4,7 @@
 
 class ProductConstants
 {
-    const DESTROY = 'Product removed successfully.';
-    const STORE = 'Product created successfully.';
-    const UPDATE = 'Product updated successfully.';
+    public const DESTROY = 'Product removed successfully.';
+    public const STORE = 'Product created successfully.';
+    public const UPDATE = 'Product updated successfully.';
 }

app/Constants/ValidationConstants.php

@@ -4,5 +4,5 @@
 
 class ValidationConstants
 {
-    const ERROR = 'Validation errors.';
+    public const ERROR = 'Validation errors.';
 }

app/Events/UserRegistered.php

@@ -3,17 +3,15 @@
 namespace App\Events;
 
 use App\Models\User;
-use Illuminate\Broadcasting\Channel;
 use Illuminate\Broadcasting\InteractsWithSockets;
-use Illuminate\Broadcasting\PresenceChannel;
-use Illuminate\Broadcasting\PrivateChannel;
-use Illuminate\Contracts\Broadcasting\ShouldBroadcast;
 use Illuminate\Foundation\Events\Dispatchable;
 use Illuminate\Queue\SerializesModels;
 
 class UserRegistered
 {
-    use Dispatchable, InteractsWithSockets, SerializesModels;
+    use Dispatchable;
+    use InteractsWithSockets;
+    use SerializesModels;
 
     /**
      * @var User

app/Http/Controllers/API/Auth/LoginController.php

@@ -2,12 +2,12 @@
 
 namespace App\Http\Controllers\API\Auth;
 
-use App\Http\Requests\AuthRequest;
-use Illuminate\Http\JsonResponse;
-use Illuminate\Support\Facades\Auth;
 use App\Constants\AuthConstants;
 use App\Http\Controllers\Controller;
+use App\Http\Requests\AuthRequest;
 use App\Http\Traits\HttpResponses;
+use Illuminate\Http\JsonResponse;
+use Illuminate\Support\Facades\Auth;
 
 class LoginController extends Controller
 {

app/Http/Controllers/API/Auth/RegisterController.php

@@ -2,10 +2,10 @@
 
 namespace App\Http\Controllers\API\Auth;
 
-use App\Http\Requests\RegisterRequest;
 use App\Constants\AuthConstants;
 use App\Events\UserRegistered;
 use App\Http\Controllers\Controller;
+use App\Http\Requests\RegisterRequest;
 use App\Http\Traits\HttpResponses;
 use App\Models\User;
 use Illuminate\Http\JsonResponse;

app/Http/Controllers/API/CategoryController.php

@@ -2,19 +2,20 @@
 
 namespace App\Http\Controllers\API;
 
-use App\Models\Category;
-use Illuminate\Http\JsonResponse;
 use App\Constants\AuthConstants;
 use App\Constants\CategoryConstants;
 use App\Http\Controllers\Controller;
 use App\Http\Requests\CategoryRequest;
 use App\Http\Resources\CategoryResource;
 use App\Http\Traits\Access;
 use App\Http\Traits\HttpResponses;
+use App\Models\Category;
+use Illuminate\Http\JsonResponse;
 
 class CategoryController extends Controller
 {
-    use HttpResponses, Access;
+    use Access;
+    use HttpResponses;
 
     /**
      * @return JsonResponse

app/Http/Controllers/API/ProductController.php

@@ -6,16 +6,17 @@
 use App\Constants\ProductConstants;
 use App\Http\Controllers\Controller;
 use App\Http\Requests\ProductRequest;
-use App\Http\Traits\HttpResponses;
 use App\Http\Resources\ProductResource;
 use App\Http\Traits\Access;
+use App\Http\Traits\HttpResponses;
 use App\Models\Category;
 use App\Models\Product;
 use Illuminate\Http\JsonResponse;
 
 class ProductController extends Controller
 {
-    use HttpResponses, Access;
+    use Access;
+    use HttpResponses;
 
     /**
      * @return JsonResponse

app/Http/Traits/Access.php

@@ -2,14 +2,14 @@
 
 namespace App\Http\Traits;
 
-use Illuminate\Support\Facades\Auth;
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Support\Facades\Auth;
 
 trait Access
 {
     /**
      * @param Model $model
-     * @return boolean
+     * @return bool
      */
     protected function canAccess(Model $model): bool
     {

app/Jobs/UserRegisteredEmailJob.php

@@ -4,16 +4,17 @@
 
 use App\Models\User;
 use Illuminate\Bus\Queueable;
-use Illuminate\Contracts\Queue\ShouldBeUnique;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
-use Illuminate\Support\Facades\Log;
 
 class UserRegisteredEmailJob implements ShouldQueue
 {
-    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
+    use Dispatchable;
+    use InteractsWithQueue;
+    use Queueable;
+    use SerializesModels;
 
     /**
      * @var User

app/Listeners/UserRegisteredEmailNotification.php

@@ -5,7 +5,6 @@
 use App\Events\UserRegistered;
 use App\Jobs\UserRegisteredEmailJob;
 use Illuminate\Contracts\Queue\ShouldQueue;
-use Illuminate\Queue\InteractsWithQueue;
 
 class UserRegisteredEmailNotification implements ShouldQueue
 {

app/Models/Category.php

@@ -2,10 +2,10 @@
 
 namespace App\Models;
 
-use Illuminate\Database\Eloquent\Factories\HasFactory;
-use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Collection;
+use Illuminate\Database\Eloquent\Factories\HasFactory;
+use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Illuminate\Database\Eloquent\Relations\BelongsToMany;
 use Illuminate\Support\Facades\Auth;

app/Models/User.php

@@ -4,14 +4,16 @@
 
 // use Illuminate\Contracts\Auth\MustVerifyEmail;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
+use Illuminate\Database\Eloquent\Relations\HasMany;
 use Illuminate\Foundation\Auth\User as Authenticatable;
 use Illuminate\Notifications\Notifiable;
 use Laravel\Sanctum\HasApiTokens;
-use Illuminate\Database\Eloquent\Relations\HasMany;
 
 class User extends Authenticatable
 {
-    use HasApiTokens, HasFactory, Notifiable;
+    use HasApiTokens;
+    use HasFactory;
+    use Notifiable;
 
     /**
      * The attributes that are mass assignable.

routes/api.php

@@ -4,21 +4,8 @@
 use App\Http\Controllers\API\Auth\RegisterController;
 use App\Http\Controllers\API\CategoryController;
 use App\Http\Controllers\API\ProductController;
-use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Route;
 
-/*
-|--------------------------------------------------------------------------
-| API Routes
-|--------------------------------------------------------------------------
-|
-| Here is where you can register API routes for your application. These
-| routes are loaded by the RouteServiceProvider and all of them will
-| be assigned to the "api" middleware group. Make something great!
-|
-*/
-
-
 Route::post('login', [LoginController::class, 'login']);
 Route::post('register', RegisterController::class);