headless_ie_selenium. Windows Explorer does not start up in the headless desktop anymore. #16

Author: kybu

README.md

@@ -23,6 +23,18 @@ Ruby, ...).
 
 Binaries can be downloaded from https://github.com/kybu/headless-selenium-for-win/releases 
 
+# Firefox & Chrome
+
+Selenium uses "drivers" to control web browsers. They are standalone
+executables driving browsers. `headless_ie_selenium.exe` by default looks
+for the IE driver in `PATH`, but it can be instructed to use other drivers
+as well. All command line arguments are forwarded to the driver, so the
+`HEADLESS_DRIVER` environment variable is used to specify the driver. Put
+the driver in one of the `PATH` directories.
+
+Set the `HEADLESS_SERVER` environment variable to `geckodriver.exe` for
+headless Firefox.
+
 # Internet Explorer
 
 When using IE, please pay full attention to configure the driver correctly. All
@@ -128,8 +140,10 @@ only on rare occasions:
 
 ## headless_ie_selenium.exe
 
-This executable runs IE Webdriver `IEDriverServer.exe` headlessly. It is meant to be used by Selenium Webdriver
-library instead of IE Webdriver.
+This executable runs IE Webdriver `IEDriverServer.exe` headlessly. It is
+meant to be used by Selenium Webdriver library instead of IE Webdriver.
+Other Selenium drivers can be used by specifying `HEADLESS_DRIVER`
+environment variable.
 
 ## desktop_utils.exe
 
@@ -155,9 +169,10 @@ Command line options:
 
 Tested on Win 7.
 
-Supported browsers at the moment: IE.
+Supported browsers: IE, Firefox, Chrome.
 
-Developed using VS 2013 Express, Boost 1.59
+Developed using VS 2013 Express, Boost 1.59 and a bit of system level
+programming skills.
 
 # License
 

desktop_utils/desktop_utils.cpp

@@ -33,7 +33,7 @@ string headlessCmd,
        switchToDesktop,
 
        header = (bo::format(
-         "Desktop utils v%1%.%2%.alpha1, Peter Vrabel (c) 2014-2017")
+         "Desktop utils v%1%.%2%, Peter Vrabel (c) 2014-2017")
          % version[0] % version[1]).str();
 bool noExplorer = false;
 

headless_ie_selenium/headless_ie_selenium.cpp

@@ -94,7 +94,7 @@ string findSeleniumDriver(const string &driver) {
   return bo::to_utf8(buffer.get());
 }
 
-Desktop::ProcessInTheJob explorerInfo, driverInfo;
+Desktop::ProcessInTheJob driverInfo;
 HANDLE jobHandle = 0;
 HDESK desktopHandle = 0;
 
@@ -107,7 +107,7 @@ void cleanUp() {
 
   auto topWindows = Desktop::allTopLevelWindows(desktopName);
   LOGD << "Top level windows in the headless desktop: " << topWindows.size();
-
+    
   for (HWND w : topWindows) {
     LOGT << (bo::format("Quitting the '%1%' top level window.") % w).str();
 
@@ -119,8 +119,6 @@ void cleanUp() {
   LOGD << "Top level windows after sending the quit msg: "
        << Desktop::allTopLevelWindows(desktopName).size();
 
-  Process::wait(explorerInfo.processInfo.hProcess);
-
   if (jobHandle) {
     LOGD << "Going to close the job object.";
     CloseHandle(jobHandle);
@@ -180,41 +178,22 @@ int _tmain(int argc, _TCHAR* argv[])
     SetConsoleCtrlHandler((PHANDLER_ROUTINE)ctrlHandler, TRUE);
 
     desktopHandle = Desktop::create(desktopName);
-    explorerInfo = Desktop::createProcessInTheJob(
+    
+    driverInfo = Desktop::createProcessInTheJob(
       desktopName,
-      "c:\\Windows\\explorer.exe");
+      selDriverPath,
+      cmdLine);
 
-    if (explorerInfo.status == explorerInfo.COULD_NOT_ASSIGN_JOB) {
+    if (driverInfo.status == driverInfo.COULD_NOT_ASSIGN_JOB) {
       LOGW << "WARN: Could not use Windows job objects! "
               "That means the cleaning-up procedure might not be reliable.";
-      ResumeThread(explorerInfo.processInfo.hThread);
+      ResumeThread(driverInfo.processInfo.hThread);
     }
-    CloseHandle(explorerInfo.processInfo.hThread);
-    jobHandle = explorerInfo.jobHandle;
-
-    Sleep(2000);
-
-    if (explorerInfo.status == explorerInfo.COULD_NOT_ASSIGN_JOB) {
-      auto pi = Desktop::createProcess(
-        desktopName,
-        selDriverPath,
-        cmdLine);
-
-      driverInfo = Desktop::ProcessInTheJob(
-        Desktop::ProcessInTheJob::COULD_NOT_ASSIGN_JOB,
-        0,
-        pi);
-    }
-    else 
-      driverInfo = Desktop::createProcessInTheJob(
-        desktopName,
-        selDriverPath,
-        cmdLine,
-        jobHandle);
+    jobHandle = driverInfo.jobHandle;
 
     CloseHandle(driverInfo.processInfo.hThread);
-
     Process::wait(driverInfo.processInfo.hProcess);
+    CloseHandle(driverInfo.processInfo.hProcess);
 
     cleanUp();
   }