rename SetPathFor404 to DotNoUseURLFor404

Author: therealak12

echoprometheus/prometheus.go

@@ -74,9 +74,9 @@ type MiddlewareConfig struct {
 
 	timeNow func() time.Time
 
-	// If SetPathFor404 is false, all 404 responses (due to non-matching route) will have the same `url` label and
+	// If DotNoUseURLFor404 is false, all 404 responses (due to non-matching route) will have the same `url` label and
 	// thus won't generate new metrics.
-	SetPathFor404 *bool
+	DotNoUseURLFor404 *bool
 }
 
 type LabelValueFunc func(c echo.Context, err error) string
@@ -148,9 +148,9 @@ func NewMiddlewareWithConfig(config MiddlewareConfig) echo.MiddlewareFunc {
 // ToMiddleware converts configuration to middleware or returns an error.
 func (conf MiddlewareConfig) ToMiddleware() (echo.MiddlewareFunc, error) {
 	// for backwared compatiblity
-	if conf.SetPathFor404 == nil {
+	if conf.DotNoUseURLFor404 == nil {
 		setPathFor404 := true
-		conf.SetPathFor404 = &setPathFor404
+		conf.DotNoUseURLFor404 = &setPathFor404
 	}
 
 	if conf.timeNow == nil {
@@ -278,7 +278,7 @@ func (conf MiddlewareConfig) ToMiddleware() (echo.MiddlewareFunc, error) {
 			values[1] = c.Request().Method
 			values[2] = c.Request().Host
 			// as of Echo v4.10.1 an empty c.Path() means the router did not find any matching routes (404)
-			if c.Path() != "" || (conf.SetPathFor404 != nil && *conf.SetPathFor404) {
+			if c.Path() != "" || (conf.DotNoUseURLFor404 != nil && *conf.DotNoUseURLFor404) {
 				values[3] = url
 			}
 			for _, cv := range customValuers {

echoprometheus/prometheus_test.go

@@ -283,7 +283,7 @@ func TestSetPathFor404NoMatchingRoute(t *testing.T) {
 	e := echo.New()
 
 	setPathFor404 := false
-	e.Use(NewMiddlewareWithConfig(MiddlewareConfig{SetPathFor404: &setPathFor404, Subsystem: defaultSubsystem}))
+	e.Use(NewMiddlewareWithConfig(MiddlewareConfig{DotNoUseURLFor404: &setPathFor404, Subsystem: defaultSubsystem}))
 	e.GET("/metrics", NewHandler())
 
 	assert.Equal(t, http.StatusNotFound, request(e, "/nonExistentPath"))
@@ -302,7 +302,7 @@ func TestSetPathFor404Logic(t *testing.T) {
 	e := echo.New()
 
 	setPathFor404 := false
-	e.Use(NewMiddlewareWithConfig(MiddlewareConfig{SetPathFor404: &setPathFor404, Subsystem: defaultSubsystem}))
+	e.Use(NewMiddlewareWithConfig(MiddlewareConfig{DotNoUseURLFor404: &setPathFor404, Subsystem: defaultSubsystem}))
 	e.GET("/metrics", NewHandler())
 
 	e.GET("/sample", echo.NotFoundHandler)