Fails to parse JSON, doesn't give us the raw response.

[ponelat]

For particular reasons, the response from the server is a malformed JSON string, ie: it will fail to parse.
However we'd still like to show the raw body content but can't because superagent doesn't include that data.

Can we have the err callback included the raw response.

Round about here I think...
https://github.com/visionmedia/superagent/blob/master/lib/client.js#L466-L473

[darxtrix]

Yeah, I am having the same problem. Actually superagent checks the Content-Type of the returned response. If the content is text itself but if the content type is wrong like application/json , it tries to parse it. If an error occurs during parsing, double callback error is thrown and res is not set.

[catc]

Same issue here. Response from API is plain text but the header is text/json which causes superagent to throw the double callback error.

[darxtrix]

There should be some option to get the raw response text in case the JSON parsing fails ?

[reicolina]

I added a .rawResponse property to the err object if the parsing fails. The code is pending approval in pull request #716

[darxtrix]

@reinaldo13 Great !

[FoghostCn]

I had the same problem, content-type is application/json but failed to parse,then it warned double callback!

[anthonyhastings]

Same here; I'm purposefully sending back malformed JSON (as that's what numerous Google scripts do to stop people injecting the resource directly onto a apage in a script tag).

A way to either disable the auto-parsing, or, somehow get the response in the error would allow me to skirt around this problem.

[kornelski]

#716 added rawResponse to the error. Does that solve your problem?

[anthonyhastings]

It'll certainly give a workaround for examining the error and seeing if it "really" is an error. Having some way to disable the auto-parsing sounds like it'd be pretty useful but perhaps the use cases for this functionality are too small.

Do you know when this PR will be included into a release or SuperAgent that could be pulled over NPM? When's your next release?

[kornelski]

I'll be released soon