chore(vm): unify Uint256 usage across u256 hints and split quotient via Uint512 #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JulianGCalderon
left a comment
JulianGCalderon
left a comment
There was a problem hiding this comment.
Hey @Forostovec, thanks for the contribution! Could you also update the changelog?
Comment on lines
332
to
337
| let a = Uint256::from_var_name("a", vm, ids_data, ap_tracking)?; | ||
| let a_high = a.high; | ||
| //Main logic | ||
| //memory[ap] = 1 if 0 <= (ids.a.high % PRIME) < 2 ** 127 else 0 | ||
| let result: Felt252 = | ||
| if *a_high >= Felt252::ZERO && a_high.as_ref() <= &Felt252::from(i128::MAX) { | ||
| if *a_high.as_ref() >= Felt252::ZERO && a_high.as_ref() <= &Felt252::from(i128::MAX) { |
Contributor
There was a problem hiding this comment.
This would imply fetching a.low, but not using it, right?
Comment on lines
398
to
406
| let div = if div_offset_low == 0 && div_offset_high == 1 { | ||
| // Standard Uint256 layout | ||
| Uint256::from_var_name("div", vm, ids_data, ap_tracking)? | ||
| } else { | ||
| let div_addr = get_relocatable_from_var_name("div", vm, ids_data, ap_tracking)?; | ||
| Uint256::from_base_addr_with_offsets(div_addr, "div", vm, div_offset_low, div_offset_high)? | ||
| }; | ||
| let div_low = div.low.as_ref(); | ||
| let div_high = div.high.as_ref(); |
Contributor
There was a problem hiding this comment.
Here could we call from_base_addr_with_offsets directly and avoid the conditional? It would make the function easier to read.
Also, in this function we are packing the U256 into a bigint manually. Could you modify it to call pack? Given that this PR is for unifying U256 usage in general, we can include it.
Collaborator
|
Hi, @Forostovec, what's the status of this PR? |
Author
Ohh, I'm sorry, gonna make chamges and update changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes remove duplicated packing logic, standardize error paths, and align uint256 hint implementations with the existing UintNNN helper patterns