fix(levm): propagate database errors (#2639)

**Motivation**

<!-- Why does this pull request exist? What are its goals? -->
- We were just propagating Internal errors but we also want to propagate
DatabaseErrors. Before this we were just reverting the transaction and
that is wrong.

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #issue_number

Author: JereSalo

crates/vm/errors.rs

@@ -118,8 +118,7 @@ impl From<RevmError<ExecutionDBError>> for EvmError {
 
 impl From<VMError> for EvmError {
     fn from(value: VMError) -> Self {
-        if value.is_internal() {
-            // We don't categorize our internal errors yet, so we label them as "Custom"
+        if value.should_propagate() {
             EvmError::Custom(value.to_string())
         } else {
             // If an error is not internal it means it is a transaction validation error.

crates/vm/levm/src/errors.rs

@@ -24,8 +24,6 @@ pub enum VMError {
     InvalidContractPrefix,
     #[error("Very Large Number")]
     VeryLargeNumber,
-    #[error("Fatal Error")]
-    FatalError,
     #[error("Invalid Transaction")]
     InvalidTransaction,
     #[error("Revert Opcode")]
@@ -77,8 +75,10 @@ pub enum VMError {
 }
 
 impl VMError {
-    pub fn is_internal(&self) -> bool {
-        matches!(self, VMError::Internal(_))
+    /// These errors are unexpected and indicate critical issues.
+    /// They should not cause a transaction to revert silently but instead fail loudly, propagating the error.
+    pub fn should_propagate(&self) -> bool {
+        matches!(self, VMError::Internal(_)) || matches!(self, VMError::DatabaseError(_))
     }
 }
 

crates/vm/levm/src/execution_handlers.rs

@@ -28,7 +28,7 @@ impl<'a> VM<'a> {
                 logs: std::mem::take(&mut current_call_frame.logs),
             }),
             Err(error) => {
-                if error.is_internal() {
+                if error.should_propagate() {
                     return Err(error);
                 }
 
@@ -233,7 +233,7 @@ impl<'a> VM<'a> {
             .backups
             .pop()
             .ok_or(VMError::Internal(InternalError::CouldNotPopCallframe))?;
-        if error.is_internal() {
+        if error.should_propagate() {
             return Err(error);
         }