Skip to content

RFC: Remove IdentityInterface as type hint on ZF\Rest\Resource #4

@weierophinney

Description

@weierophinney

Currently, the setIdentity method requires the IdentityInterface (https://github.com/zfcampus/zf-rest/blob/master/src/Resource.php#L82).

This makes a lot of assumptions around what identity means to consuming applications. It makes absolutely no sense in our use case to implement the 15 methods declared in the Zend\MvcAuth\IdentityInterface and is keeping us from using the getIdentity() method on the Resource base class.

I am suggesting that we change:

    /**
     * @param null|IdentityInterface $identity
     * @return self
     */
    public function setIdentity(IdentityInterface $identity = null)
    {
        $this->identity = $identity;
        return $this;
    }

To

    /**
     * @param null|object $identity
     * @return self
     */
    public function setIdentity($identity = null)
    {
        $this->identity = $identity;
        return $this;
    }

This way, I can set our own identity object via the MvcEvent like so

$event->setParam('ZF\MvcAuth\Identity', $authService->getIdentity());

I realize that this was likely done for some other module that performs authentication/authorization if that is the case, I strongly feel those modules should enforce the interface they need instead of the Resource object.


Originally posted by @steverhoades at zfcampus/zf-rest#91

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions