Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2C function signature mistmatch in core vs mbos #26

Open
pelikhan opened this issue May 3, 2018 · 1 comment
Open

I2C function signature mistmatch in core vs mbos #26

pelikhan opened this issue May 3, 2018 · 1 comment
Assignees

Comments

@pelikhan
Copy link
Contributor

pelikhan commented May 3, 2018

The I2C function signatures in codal-core and codal-mbedos are different (uint16_t vs uint32_t). This breaks i2c in mbedos since all base class function are noops.

https://github.com/lancaster-university/codal-core/blob/master/inc/driver-models/I2C.h#L115

vs

https://github.com/lancaster-university/codal-mbedos/blob/master/inc/MbedI2C.h#L81

Is this intentional?

@jamesadevine
Copy link
Contributor

@pelikhan True, we moved codal-mbed to use the new abstract driver implementation, but not mbed-os.

https://github.com/lancaster-university/codal-mbed/blob/master/source/MbedI2C.cpp

It means that you only need to implement about three functions, and the rest is handled by the higher level abstraction.

@finneyj was there a reason why we didn't move mbedos forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants