Skip to content

Do not depend on the lance default features #240

@valkum

Description

@valkum

lance-namespace currently depends on lance including default features. lance default features are "aws", "azure", "gcp", "oss". This will pull in a lot of aws-* crates, even if you don't need any of the aws support. Because lancedb depends on lance-namespace, there is currently no way of using lancedb without the compilation of at least rustls with aws-lc-rs (enabled by one of the aws-* crates).

It doesn't look like lance-namespace actually depends on any of the default features of lance, thus I suggest adding default-features = false.

I also suggest making the selection of TLS backend to use in reqwest a feature flag.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions