community: fix perplexity response parameters not being included in model response#30440
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
Bot
added
size:L
bug
|
|
||
| chunk = self._convert_delta_to_message_chunk( | ||
| choice["delta"], default_chunk_class | ||
| choice["delta"], default_chunk_class, additional_kwargs |
There was a problem hiding this comment.
nitpick but could we update chunk.additional_kwargs below in this function, as we were doing before, instead of passing it into _convert_delta_to_message_chunk and mutating it there?
There was a problem hiding this comment.
I've updated the code to add additional_kwargs after calling _convert_delta_to_message_chunk, rather than modifying it inside the function. 👌
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the handling of additional keyword arguments in the Perplexity chat model responses and adds new tests to verify that citations, images, and related questions are correctly included.
- Updated the _stream and _generate methods in perplexity.py to merge additional keyword arguments from API responses.
- Added new unit tests to verify that the stream method correctly includes citations with images and related questions.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libs/community/langchain_community/chat_models/perplexity.py | Updated _stream and _generate to build and merge additional_kwargs from API responses. |
| libs/community/tests/unit_tests/chat_models/test_perplexity.py | Added tests to verify that citations, images, and related_questions are included in the streamed output. |
Comments suppressed due to low confidence (2)
libs/community/tests/unit_tests/chat_models/test_perplexity.py:122
- [nitpick] The test function's docstring indicates it only checks citations, yet the test also verifies that images are included. Consider updating the docstring to accurately reflect that both citations and images are being tested.
def test_perplexity_stream_includes_citations_and_images(mocker: MockerFixture) -> None:
libs/community/tests/unit_tests/chat_models/test_perplexity.py:211
- [nitpick] The test function's docstring states it only checks citations while the test verifies both citations and related questions. Update the docstring for clarity.
def test_perplexity_stream_includes_citations_and_related_questions(mocker: MockerFixture) -> None:
This pull request includes enhancements to the
perplexity.pyfile in thechat_modelsmodule, focusing on improving the handling of additional keyword arguments (additional_kwargs) in message processing methods. Additionally, new unit tests have been added to ensure the correct inclusion of citations, images, and related questions in theadditional_kwargs.Issue: resolves #30439
Enhancements to
perplexity.py:libs/community/langchain_community/chat_models/perplexity.py: Modified the_convert_delta_to_message_chunk,_stream, and_generatemethods to handleadditional_kwargs, which include citations, images, and related questions. [1] [2] [3]New unit tests:
libs/community/tests/unit_tests/chat_models/test_perplexity.py: Added new teststest_perplexity_stream_includes_citations_and_imagesandtest_perplexity_stream_includes_citations_and_related_questionsto verify that thestreammethod correctly includes citations, images, and related questions in theadditional_kwargs.