-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
Summary
The NOVA backend for SAMMY execution has been disabled in the codebase. The nova-galaxy package required for this backend is unstable and not a development priority.
Background
PLEIADES supports three SAMMY execution backends:
- Local - Direct execution using local SAMMY binary (primary)
- Docker - Containerized execution (secondary)
- NOVA - ORNL web service execution (disabled)
Why NOVA is Disabled
- Package instability: The
nova-galaxypackage (required dependency) is not stable - No immediate plan: There is no immediate plan to make PLEIADES fully support NOVA
- Development focus: Current development priorities are:
- MCP (Model Context Protocol) integration for AI-assisted workflows
- 2D resonance fitting capabilities
- Core functionality improvements
Code Changes
The following changes were made to disable NOVA:
src/pleiades/sammy/factory.py
- Commented out
NovaSammyRunnerimport - Added
_NOVA_AVAILABLE = Falseflag list_available_backends()now returnsFalsefor NOVAcreate_runner()raisesBackendNotAvailableErrorif NOVA is requested
Tests
tests/unit/pleiades/sammy/backends/test_nova.py- Entire module skippedtests/unit/pleiades/sammy/test_factory.py- NOVA tests skippedtests/unit/pleiades/sammy/test_config.py-TestNovaSammyConfigclass skipped
Code Preserved
The NOVA backend implementation code remains in the codebase for future use:
src/pleiades/sammy/backends/nova_ornl.py- Full implementationsrc/pleiades/sammy/config.py-NovaSammyConfigclass
Re-enabling NOVA
When the nova-galaxy package stabilizes, NOVA support can be re-enabled by:
-
Uncommenting the import in
factory.py:from pleiades.sammy.backends.nova_ornl import NovaSammyRunner
-
Setting the flag:
_NOVA_AVAILABLE = True
-
Removing skip markers from tests
Related
- Development focus: MCP integration ([Epic] MCP Server Integration #163), 2D resonance fitting
- Supported backends: Local (recommended), Docker (containerized)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels