addresses reviews

raftx24 · raftx24 · commit fc6de538ba0c · 2021-01-15T16:18:16.000+03:30
diff --git a/src/Models/Task.php b/src/Models/Task.php
@@ -59,13 +59,6 @@ public function scopeCompleted($query)
         return $query->whereCompleted(true);
     }
 
-    public function scopeSetDone($query)
-    {
-        return $query->update([
-            'completed' => true,
-        ]);
-    }
-
     public function setReminderAttribute($dateTime)
     {
         if (Carbon::now()->lessThan($dateTime)) {
diff --git a/src/Services/TaskableFactory.php b/src/Services/TaskableFactory.php
@@ -5,7 +5,7 @@
 use LaravelEnso\Tasks\Contracts\Taskable;
 use LaravelEnso\Tasks\Models\Task;
 
-class TaskFactory
+class TaskableFactory
 {
     public function create(Taskable $taskable): Task
     {

Original file line number	Diff line number	Diff line change
`@@ -59,13 +59,6 @@ public function scopeCompleted($query)`
`59`	`59`	`return $query->whereCompleted(true);`
`60`	`60`	`}`
`61`	`61`
`62`		`- public function scopeSetDone($query)`
`63`		`- {`
`64`		`- return $query->update([`
`65`		`- 'completed' => true,`
`66`		`- ]);`
`67`		`- }`
`68`		`-`
`69`	`62`	`public function setReminderAttribute($dateTime)`
`70`	`63`	`{`
`71`	`64`	`if (Carbon::now()->lessThan($dateTime)) {`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`use LaravelEnso\Tasks\Contracts\Taskable;`
`6`	`6`	`use LaravelEnso\Tasks\Models\Task;`
`7`	`7`
`8`		`-class TaskFactory`
	`8`	`+class TaskableFactory`
`9`	`9`	`{`
`10`	`10`	`public function create(Taskable $taskable): Task`
`11`	`11`	`{`