Happy flow detected on query builder on delete function

[macropay-solutions]

On this line

framework/src/Illuminate/Database/Query/Builder.php

Line 4019 in 966a22a

$this->where($this->from.'.id', '=', $id);

someone thought that his happy flow will suit all and this overhead should be included in laravel.

Of course this will not work if the table does not have an id column (maybe also when the table is aliased).

We had to extend this function and the solution we implemented was this:

        if (!\is_null($id)) {
            throw new \RuntimeException(
                'Happy flow not allowed. There is no way of knowing the primary key name in query builder'
            );
        }

[shaedrich]

Wow, this was there in some shape or form since the very first commit: de69bb2

Impressive ^^

Yeah, only Eloquent's query builder can access this information from the model. The database query builder would have to do this via an extra query via the schema, which would not be ideal.