Code tweak: new "mode" prop. #4738
-
In FormField.js, the prop "mode" is being declared instead of mapped via mapProps. It is now: props: {
...mapProps([
'shownViaNewRelationModal',
'field',
'viaResource',
'viaResourceId',
'viaRelationship',
'resourceName',
'showHelpText',
]),
formUniqueId: {
type: String,
},
mode: {
type: String,
default: 'form',
validator: v => ['form', 'modal'].includes(v),
},
}, It should be: props: {
...mapProps([
'shownViaNewRelationModal',
'field',
'viaResource',
'viaResourceId',
'viaRelationship',
'resourceName',
'showHelpText',
'mode'
]),
formUniqueId: {
type: String,
},
}, Also... I believe the DependentFormField.js should have this prop. |
Beta Was this translation helpful? Give feedback.
Answered by
crynobone
Aug 26, 2022
Replies: 1 comment 2 replies
-
Changes to |
Beta Was this translation helpful? Give feedback.
2 replies
Answer selected by
crynobone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Changes to
FormField
has been made, changes toDependentFormField
is not required since it doesn't use it.