Inconsistency in the translation of the action text in notifications #5050
Unanswered
szymon-szychulski
asked this question in
Ideas & Feature Requests
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Description:
src/Notifications/NovaNotification.php:152
:Why the value passed to the
text
parameter in theaction
method onNovaNotification
is automatically translated, while the field label in Nova and other labels are not automatically translated and the developer has a choice of what exactly to set?Assuming my website is in several languages where the default language is romanian and my admin panel has no translations used anywhere, I don't want English-speaking panel staff to see the text of the action in romanian. Fields and other Nova elements give a full selection here and are not translation-dependent.
Detailed steps to reproduce the issue on a fresh Nova installation:
By executing the following code on the user model, for example in any controller:
If there is a translation for the phrase 'Show' in the translations, it will be automatically applied when it shouldn't.
Beta Was this translation helpful? Give feedback.
All reactions