Port codebase to Python3 (smogon#2)

* Make script compatible with Python 3
* Remove Stats/ dir
* Remove superfluous encode stuff
* Remove orjson
* Catch cases where trainer names have Unicode
* Remove Python 2 bug
* Convert `json.loads(file.read())` to `json.load(file)`
* Clarifying why we have extra encodes and decodes
* Add correct file opening options
* Revert file context code; will just be done later
* Fix variable names
* Update batchLogReader.py
* Update environment.yml

Co-authored-by: Christopher Monsanto <[email protected]>

Author: shrianshChari

MegaCounter.py

@@ -5,7 +5,9 @@
 from TA import megas
 from common import keyify
 
-stats=json.load(open(sys.argv[1]))
+file = open(sys.argv[1])
+stats=json.load(file)
+file.close()
 
 megastats=[]
 total=0
@@ -33,5 +35,5 @@
 
 megastats=sorted(megastats, key=lambda megastats:-megastats[1])
 for mega in megastats:
-	print "%-18s%8.5f%%" % (mega[0],600.0*mega[1]/total)
+	print("%-18s%8.5f%%" % (mega[0],600.0*mega[1]/total))
 

PS-Extractor.py

@@ -4,7 +4,7 @@
 used on Pokemon Showdown and pull out the data that's needed for the scripts."""
 
 import json
-import cPickle as pickle
+import pickle
 from onix import contexts
 
 ctx = contexts.get_standard_context(force_refresh=True)
@@ -30,6 +30,6 @@
 for k, v in ctx.natures.items():
     keyLookup[k] = v['name']
 
-json.dump(baseStats, open('baseStats.json', 'w+'))
-json.dump(types, open('types.json', 'w+'))
-pickle.dump(keyLookup, open('keylookup.pickle', 'w+'))
+json.dump(baseStats, open('baseStats.json', 'w'))
+json.dump(types, open('types.json', 'w'))
+pickle.dump(keyLookup, open('keylookup.pickle', 'wb'))

StatCounter.py

@@ -23,9 +23,8 @@
 import string
 import sys
 import math
-import cPickle as pickle
+import pickle
 import os
-#import ujson as json
 import json
 import gzip
 
@@ -66,10 +65,6 @@
 	metagamefile=open(filename,'w')
 else:
 	metagamefile=False
-filename="Raw/moveset/"+tier+"/teammate"+specs+".pickle"
-teammatefile=open(filename,'w')
-filename="Raw/moveset/"+tier+"/encounterMatrix"+specs+".pickle"
-encounterfile=open(filename,'w')
 
 
 battleCount = 0
@@ -94,7 +89,7 @@
 	t=t[:-11]
 
 for line in file:
-	#print line
+	#print(line)
 	battles = json.loads(line)
 
 	for battle in battles:
@@ -190,8 +185,8 @@
 			if 'empty' in leads:
 				if len(battle['matchups']) == 0: #1v1 (or similiar) battle forfeited before started
 					continue
-				print "Something went wrong."
-				print battle
+				print("Something went wrong.")
+				print(battle)
 
 			for i in range(2):
 				if ['p1','p2'][i] not in weight:
@@ -240,9 +235,13 @@
 
 
 #write teammates and encounter matrix to file
-pickle.dump(teammateMatrix,teammatefile)
+filename="Raw/moveset/"+tier+"/teammate"+specs+".pickle"
+teammatefile=open(filename,'wb')
+pickle.dump(teammateMatrix, teammatefile)
 teammatefile.close()
-pickle.dump(encounterMatrix,encounterfile)
+filename="Raw/moveset/"+tier+"/encounterMatrix"+specs+".pickle"
+encounterfile = open(filename, 'wb')
+pickle.dump(encounterMatrix, encounterfile)
 encounterfile.close()
 
 #sort by weighted usage
@@ -316,8 +315,8 @@
 
 	if stallCounter:
 		#figure out a good bin range by looking at .1% and 99.9% points
-		low = stallCounter[len(stallCounter)/1000][0]
-		high = stallCounter[len(stallCounter)-len(stallCounter)/1000-1][0]
+		low = stallCounter[len(stallCounter)//1000][0]
+		high = stallCounter[len(stallCounter)-len(stallCounter)//1000-1][0]
 
 
 		nbins = 13 #this is actually only a rough idea--I think it might be the minimum?
@@ -347,7 +346,12 @@
 		nbins = len(histogram)
 
 		for start in range(len(stallCounter)):
-			if stallCounter[start] >= histogram[0][0]-binSize/2:
+			# In Python 2, you could compare a list to a number, and the
+			# list would always be greater than or equal to the number.
+			# In other words, the commented statement (which would fail in
+			# Python 3) would always return True.
+			# if stallCounter[start] >= histogram[0][0]-binSize/2:
+			if True:
 				break
 
 		j=0
@@ -373,7 +377,7 @@
 				x=x+score[0]*score[1]
 				y=y+score[1]	
 
-			#print histogram
+			#print(histogram)
 			metagamefile.write(' Stalliness (mean: %6.3f)\n'%(x/y))
 			for i in range(len(histogram)):
 				if histogram[i][0]%(2.0*binSize) < binSize/2:

TA.py

@@ -7,7 +7,6 @@
 
 import string
 import sys
-#import ujson as json
 import json
 import math
 import copy

TierUpdate9Doubles.py

@@ -1,7 +1,7 @@
 import string
 import sys
 import json
-import cPickle as pickle
+import pickle
 from common import keyify,readTable,getBattleFormatsData
 reload(sys)
 sys.setdefaultencoding('utf8')
@@ -16,18 +16,18 @@ def getUsage(filename,col,weight,usage):
 
 def makeTable(table,name,keyLookup):
 
-	print "[HIDE="+name+"][CODE]"
-	print "Combined usage for "+name
-	print " + ---- + ------------------ + ------- + "
-	print " | Rank | Pokemon            | Percent | "
-	print " + ---- + ------------------ + ------- + "
-	print ' | %-4d | %-18s | %6.3f%% |' % (1,keyLookup[table[0][0]],table[0][1]*100)
+	print("[HIDE="+name+"][CODE]")
+	print("Combined usage for "+name)
+	print(" + ---- + ------------------ + ------- + ")
+	print(" | Rank | Pokemon            | Percent | ")
+	print(" + ---- + ------------------ + ------- + ")
+	print(' | %-4d | %-18s | %6.3f%% |' % (1,keyLookup[table[0][0]],table[0][1]*100))
 	for i in range(1,len(table)):
 		if table[i][1] < 0.001:
 			break
-		print ' | %-4d | %-18s | %6.3f%% |' % (i+1,keyLookup[table[i][0]],100.0*table[i][1])
-	print " + ---- + ------------------ + ------- + "
-	print "[/CODE][/HIDE]"
+		print(' | %-4d | %-18s | %6.3f%% |' % (i+1,keyLookup[table[i][0]],100.0*table[i][1]))
+	print(" + ---- + ------------------ + ------- + ")
+	print("[/CODE][/HIDE]")
 
 tiers = ['DUber','DOU', 'DUU', 'DNU']
 usageTiers = ['doublesou', 'doublesuu']
@@ -76,8 +76,8 @@ def main(months):
 
 	usage = {} #track usage across all relevant tiers [OU,UU,RU,NU]
 
-	for i in xrange(len(months)):
-		for j in xrange(len(usageTiers)):		
+	for i in range(len(months)):
+		for j in range(len(usageTiers)):		
 			n = {}
 			u = {}
 
@@ -165,7 +165,7 @@ def main(months):
 		if poke not in newTiers.keys():
 			newTiers[poke] = tiers[-1]
 
-	print ""
+	print("")
 	for poke in curTiers:
 		if newTiers[poke] == 'New' and poke in NFE:
 			continue
@@ -176,7 +176,7 @@ def main(months):
 				if tiers.index(newTiers[base]) < tiers.index(newTiers[poke]): #if the base is in a higher tier
 					newTiers[poke] = newTiers[base]
 					continue
-			print species+" moved from "+curTiers[poke]+" to "+newTiers[poke]
+			print(species+" moved from "+curTiers[poke]+" to "+newTiers[poke])
 
 if __name__ == "__main__":
     main(sys.argv[1:])

TierUpdate9LC.py

@@ -1,7 +1,7 @@
 import string
 import sys
 import json
-import cPickle as pickle
+import pickle
 from common import keyify,readTable,getBattleFormatsData
 reload(sys)
 sys.setdefaultencoding('utf8')
@@ -28,18 +28,18 @@ def usageToTiers(usage):
 
 def makeTable(table,name,keyLookup):
 
-	print "[HIDE="+name+"][CODE]"
-	print "Combined usage for "+name
-	print " + ---- + ------------------ + ------- + "
-	print " | Rank | Pokemon            | Percent | "
-	print " + ---- + ------------------ + ------- + "
-	print ' | %-4d | %-18s | %6.3f%% |' % (1,keyLookup[table[0][0]],table[0][1]*100)
+	print("[HIDE="+name+"][CODE]")
+	print("Combined usage for "+name)
+	print(" + ---- + ------------------ + ------- + ")
+	print(" | Rank | Pokemon            | Percent | ")
+	print(" + ---- + ------------------ + ------- + ")
+	print(' | %-4d | %-18s | %6.3f%% |' % (1,keyLookup[table[0][0]],table[0][1]*100))
 	for i in range(1,len(table)):
 		if table[i][1] < 0.001:
 			break
-		print ' | %-4d | %-18s | %6.3f%% |' % (i+1,keyLookup[table[i][0]],100.0*table[i][1])
-	print " + ---- + ------------------ + ------- + "
-	print "[/CODE][/HIDE]"
+		print(' | %-4d | %-18s | %6.3f%% |' % (i+1,keyLookup[table[i][0]],100.0*table[i][1]))
+	print(" + ---- + ------------------ + ------- + ")
+	print("[/CODE][/HIDE]")
 
 def main(months):
 	file = open('keylookup.json', 'rb')
@@ -60,7 +60,7 @@ def main(months):
 
 
 	remaining=24.0
-	for i in xrange(len(months)):
+	for i in range(len(months)):
 		tiername = 'lc'
 
 		#bh
@@ -98,7 +98,7 @@ def main(months):
 	for poke in dnuBanlist:
 		printme += keyLookup[poke]+', '
 	printme = printme[:-2]
-	print printme
+	print(printme)
 
 
 

TierUpdate9NatDex.py

@@ -1,7 +1,7 @@
 import string
 import sys
 import json
-import cPickle as pickle
+import pickle
 from common import keyify,readTable,getBattleFormatsData
 reload(sys)
 sys.setdefaultencoding('utf8')
@@ -16,18 +16,18 @@ def getUsage(filename,col,weight,usage):
 
 def makeTable(table,name,keyLookup):
 
-	print "[HIDE="+name+"][CODE]"
-	print "Combined usage for "+name
-	print " + ---- + ------------------ + ------- + "
-	print " | Rank | Pokemon            | Percent | "
-	print " + ---- + ------------------ + ------- + "
-	print ' | %-4d | %-18s | %6.3f%% |' % (1,keyLookup[table[0][0]],table[0][1]*100)
+	print("[HIDE="+name+"][CODE]")
+	print("Combined usage for "+name)
+	print(" + ---- + ------------------ + ------- + ")
+	print(" | Rank | Pokemon            | Percent | ")
+	print(" + ---- + ------------------ + ------- + ")
+	print(' | %-4d | %-18s | %6.3f%% |' % (1,keyLookup[table[0][0]],table[0][1]*100))
 	for i in range(1,len(table)):
 		if table[i][1] < 0.001:
 			break
-		print ' | %-4d | %-18s | %6.3f%% |' % (i+1,keyLookup[table[i][0]],100.0*table[i][1])
-	print " + ---- + ------------------ + ------- + "
-	print "[/CODE][/HIDE]"
+		print(' | %-4d | %-18s | %6.3f%% |' % (i+1,keyLookup[table[i][0]],100.0*table[i][1]))
+	print(" + ---- + ------------------ + ------- + ")
+	print("[/CODE][/HIDE]")
 
 tiers = ['Uber','OU','UUBL','UU','RUBL','RU','NUBL','NU','PUBL','PU','ZUBL','ZU', 'New']
 usageTiers = ['nationaldex', 'nationaldexuu']
@@ -79,8 +79,8 @@ def main(months):
 
 	usage = {} #track usage across all relevant tiers [OU,UU,RU,NU]
 
-	for i in xrange(len(months)):
-		for j in xrange(len(usageTiers)):		
+	for i in range(len(months)):
+		for j in range(len(usageTiers)):		
 			n = {}
 			u = {}
 
@@ -181,7 +181,7 @@ def main(months):
 		if poke not in newTiers.keys():
 			newTiers[poke] = 'RU'
 
-	print ""
+	print("")
 	for poke in curTiers:
 		if newTiers[poke] == 'RU' and poke in NFE:
 			continue
@@ -192,7 +192,7 @@ def main(months):
 				if tiers.index(newTiers[base]) < tiers.index(newTiers[poke]): #if the base is in a higher tier
 					newTiers[poke] = newTiers[base]
 					continue
-			print species+" moved from "+curTiers[poke]+" to "+newTiers[poke]
+			print(species+" moved from "+curTiers[poke]+" to "+newTiers[poke])
 
 if __name__ == "__main__":
     main(sys.argv[1:])

TierUpdate9Singles.py

@@ -1,7 +1,7 @@
 import string
 import sys
 import json
-import cPickle as pickle
+import pickle
 from common import keyify,readTable,getBattleFormatsData
 reload(sys)
 sys.setdefaultencoding('utf8')
@@ -16,18 +16,18 @@ def getUsage(filename,col,weight,usage):
 
 def makeTable(table,name,keyLookup):
 
-	print "[HIDE="+name+"][CODE]"
-	print "Combined usage for "+name
-	print " + ---- + ------------------ + ------- + "
-	print " | Rank | Pokemon            | Percent | "
-	print " + ---- + ------------------ + ------- + "
-	print ' | %-4d | %-18s | %6.3f%% |' % (1,keyLookup[table[0][0]],table[0][1]*100)
+	print("[HIDE="+name+"][CODE]")
+	print("Combined usage for "+name)
+	print(" + ---- + ------------------ + ------- + ")
+	print(" | Rank | Pokemon            | Percent | ")
+	print(" + ---- + ------------------ + ------- + ")
+	print(' | %-4d | %-18s | %6.3f%% |' % (1,keyLookup[table[0][0]],table[0][1]*100))
 	for i in range(1,len(table)):
 		if table[i][1] < 0.001:
 			break
-		print ' | %-4d | %-18s | %6.3f%% |' % (i+1,keyLookup[table[i][0]],100.0*table[i][1])
-	print " + ---- + ------------------ + ------- + "
-	print "[/CODE][/HIDE]"
+		print(' | %-4d | %-18s | %6.3f%% |' % (i+1,keyLookup[table[i][0]],100.0*table[i][1]))
+	print(" + ---- + ------------------ + ------- + ")
+	print("[/CODE][/HIDE]")
 
 tiers = ['Uber','New','OU','UUBL','UU','RUBL','RU','NUBL','NU','PUBL','PU','ZUBL','ZU']
 usageTiers = ['ou', 'uu', 'ru', 'nu', 'pu']
@@ -75,8 +75,8 @@ def main(months):
 
 	usage = {} #track usage across all relevant tiers [OU,UU,RU,NU]
 
-	for i in xrange(len(months)):
-		for j in xrange(len(usageTiers)):		
+	for i in range(len(months)):
+		for j in range(len(usageTiers)):		
 			n = {}
 			u = {}
 
@@ -264,7 +264,7 @@ def main(months):
 		if newTiers[poke] == 'PU' and poke in ['oricorio','oricoriopau','magneton','vivillon','sneaselhisui']:
 			newTiers[poke] = 'PUBL'
 
-	print ""
+	print("")
 	for poke in curTiers:
 		if newTiers[poke] == 'ZU' and poke in NFE:
 			continue
@@ -275,7 +275,7 @@ def main(months):
 				if tiers.index(newTiers[base]) < tiers.index(newTiers[poke]): #if the base is in a higher tier
 					newTiers[poke] = newTiers[base]
 					continue
-			print species+" moved from "+curTiers[poke]+" to "+newTiers[poke]
+			print(species+" moved from "+curTiers[poke]+" to "+newTiers[poke])
 
 if __name__ == "__main__":
     main(sys.argv[1:])