Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of connections between nodes #247

Open
aramallo opened this issue May 18, 2023 · 0 comments
Open

Reduce the number of connections between nodes #247

aramallo opened this issue May 18, 2023 · 0 comments
Assignees

Comments

@aramallo
Copy link
Collaborator

At the moment the peer_service_manager will open and maintain one connection in each direction, that is when node A connects to node B it does not take into account that maybe B already established a connection to A.

More specifically, the peer_service_manager will check the current outgoing connections i.e. partisan_peer_service_client (in v4 from its in-process state cache and in v5 using partisan_peer_service_connections which uses ets) without considering the existing incoming connections partisan_peer_service_server.

The above is contrary to what disterl does, which ensures there is always one TPC connection between two nodes. disterl does this during the handshake checking the existing connections (or in-flight connection attempts).

For Partisan, we can do the same but taking into account Channel Parallelism.

@aramallo aramallo self-assigned this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant