Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with GCC-11 (C++17 default) #39

Open
a17r opened this issue May 20, 2021 · 2 comments
Open

Fails to build with GCC-11 (C++17 default) #39

a17r opened this issue May 20, 2021 · 2 comments

Comments

@a17r
Copy link

a17r commented May 20, 2021

In file included from src/fingerprint/Fingerprint.cpp:21:
src/fingerprint/Fingerprint.h:74:49: error: ISO C++17 does not allow dynamic exception specifications
   74 |         void generate( FingerprintableSource* ) throw( Error );
      |                                                 ^~~~~
src/fingerprint/Fingerprint.h:85:86: error: ISO C++17 does not allow dynamic exception specifications
   85 |         void decode( QNetworkReply*, bool* lastfm_needs_a_complete_fingerprint = 0 ) throw( Error );
      |                                                                                      ^~~~~
src/fingerprint/Fingerprint.cpp:97:60: error: ISO C++17 does not allow dynamic exception specifications
   97 | lastfm::Fingerprint::generate( FingerprintableSource* ms ) throw( Error )
      |                                                            ^~~~~
src/fingerprint/Fingerprint.cpp:309:91: error: ISO C++17 does not allow dynamic exception specifications
  309 | lastfm::Fingerprint::decode( QNetworkReply* reply, bool* complete_fingerprint_requested ) throw( Error )
      |                                                                                           ^~~~~

Downstream report: https://bugs.gentoo.org/787128

@barracuda156
Copy link

Maybe pass -DCMAKE_CXX_STANDARD=14?

@a17r
Copy link
Author

a17r commented Dec 2, 2024

That's what we do, the point is to fix it upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants