Pass instance parameters in Setup()

[FVSoares]

I saw that begin can only send midi port number.
Is there a way to send the Session Name and UPD port number inside Setup()?
I would like to let the user choose the session name.
It looks like it was possible in older releases.

Regards

[lathoub]

replace the default construction macro APPLEMIDI_CREATE_DEFAULTSESSION_INSTANCE, with the parameterised APPLEMIDI_CREATE_INSTANCE macro (depending on your ETH hardware) :

Arduino-AppleMIDI-Library/src/AppleMIDI.h

Lines 359 to 369 in a8aceca

	#if defined(ARDUINO_ARCH_ESP32) || defined(ESP32)
	#define APPLEMIDI_CREATE_DEFAULTSESSION_INSTANCE() \
	APPLEMIDI_CREATE_INSTANCE(WiFiUDP, MIDI, "AppleMIDI-ESP32", DEFAULT_CONTROL_PORT);
	#elif defined(ESP8266)
	#define APPLEMIDI_CREATE_DEFAULTSESSION_INSTANCE() \
	APPLEMIDI_CREATE_INSTANCE(WiFiUDP, MIDI, "AppleMIDI-ESP8266", DEFAULT_CONTROL_PORT);
	#else
	#define APPLEMIDI_CREATE_DEFAULTSESSION_INSTANCE() \
	APPLEMIDI_CREATE_INSTANCE(EthernetUDP, MIDI, "AppleMIDI-Arduino", DEFAULT_CONTROL_PORT);
	#endif

The default port is set here

Arduino-AppleMIDI-Library/src/AppleMIDI_Defs.h

Line 13 in 877b39f

#define DEFAULT_CONTROL_PORT 5004

Or see this example

[lathoub]

Setting the port number in the setup section was not envisioned, as the AppleMIDI protocol implementation is a plugin to the FortySevenEffects MIDI library - with limited wiggle space in what can be called.

Also, I wanted to make it as easy as possible to switch between protocols.

Possible solution: you could add a setPort method

    void setPort(const uint16_t port)
    {
        this->port = port;
    }

and call it before you call MIDI.begin()

I have not tested the above, let me know if it works :-)

[FVSoares]

port is protected in the library and I wouldn't mess with the library before I learn a bit more.
I think this library is very good and very useful. Change port number is not that important.
Thanks for your support.

[lathoub]

port is protected in the library and I wouldn't mess with the library before I learn a bit more.

You can clone the library in your repo, make the above modif and see how it goes.

When you are ready, pls mark this discussion as "answered"

[lathoub]

I added a public method setPort, to be called before MIDI.begin()

[lathoub]

@FVSoares have you been able to test the added setPort function?

[lathoub]

@FVSoares did this work for you?

[lathoub]

@FVSoares gentle nudge, I'm preparing for a new release and want to close items that can be closed

[FVSoares]

My apologies I didn`t follow up on this. It can be closed and I tried to but I don`t know why the button to close it is not available when I log in.

…

On Fri, Aug 12, 2022 at 3:26 AM lathoub ***@***.***> wrote: @FVSoares <https://github.com/FVSoares> gentle nudge, I'm preparing for a new release and want to close items that can be closed — Reply to this email directly, view it on GitHub <#139 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWKGJHZBP75LO4MCHT7EUA3VYXVCXANCNFSM5HHBVRIA> . You are receiving this because you were mentioned.Message ID: <lathoub/Arduino-AppleMIDI-Library/repo-discussions/139/comments/3381184@ github.com>

-- Fabio Vieira Soares Eng. de Sistemas