make behavior of test helper more explicit

Author: eli-darkly

test/LaunchDarkly.EventSource.Tests/EventSourceTests.cs

@@ -354,6 +354,7 @@ public async Task Given_content_type_not_equal_to_eventstream_when_the_http_resp
             var evt = new EventSource(config);
 
             var receiver = new ErrorReceiver(evt);
+            receiver.CloseEventSourceOnError = true;
 
             //// Act
             await evt.StartAsync();
@@ -375,6 +376,7 @@ public async Task Given_204_when_the_http_response_is_received_then_error_event_
             var evt = new EventSource(new Configuration(_uri, handler));
 
             var receiver = new ErrorReceiver(evt);
+            receiver.CloseEventSourceOnError = true;
 
             //Act
             await evt.StartAsync();
@@ -402,6 +404,7 @@ public async Task Given_status_code_when_the_http_response_is_received_then_erro
             var evt = new EventSource(new Configuration(_uri, handler));
 
             ErrorReceiver receiver = new ErrorReceiver(evt);
+            receiver.CloseEventSourceOnError = true;
 
             await evt.StartAsync();
 
@@ -469,6 +472,7 @@ public async Task When_response_exceeds_read_timeout_then_read_timeout_exception
             var evt = new StubEventSource(new Configuration(_uri, handler, readTimeout: readTimeout), (int)timeout.TotalMilliseconds);
 
             var receiver = new ErrorReceiver(evt);
+            receiver.CloseEventSourceOnError = true;
 
             await evt.StartAsync();
 
@@ -519,8 +523,7 @@ public async Task When_server_returns_HTTP_error_a_reconnect_attempt_is_made()
 
             var evt = new EventSource(new Configuration(_uri, handler));
 
-            ErrorReceiver receiver = new ErrorReceiver(evt);
-            receiver.CloseEventSourceOnError = false;
+            var receiver = new ErrorReceiver(evt);
 
             string messageReceived = null;
             evt.MessageReceived += (_, e) =>
@@ -547,6 +550,7 @@ public async Task When_error_handler_closes_event_source_no_reconnect_attempt_is
             var evt = new EventSource(new Configuration(_uri, handler));
 
             var receiver = new ErrorReceiver(evt);
+            receiver.CloseEventSourceOnError = true;
 
             await evt.StartAsync();
 
@@ -556,7 +560,7 @@ public async Task When_error_handler_closes_event_source_no_reconnect_attempt_is
 
     class ErrorReceiver
     {
-        public bool CloseEventSourceOnError = true;
+        public bool CloseEventSourceOnError = false;
         public Exception ErrorReceived = null;
         public ReadyState SourceStateReceived;
         private readonly EventSource _source;