Merge pull request #34 from launchdarkly/drichelson/ch934/net-sdk-stringcontent-disposed-exception

Better handling of errors when sending events

Author: drichelson

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to the LaunchDarkly .NET SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [3.1.1] - 2017-01-16
+### Changed
+- Improved error handling when sending events
+
 ## [3.1.0] - 2016-12-07
 ### Added
 - Configurable http request timeout

src/LaunchDarkly.Client/EventProcessor.cs

@@ -68,14 +68,13 @@ void IStoreEvents.Flush()
         private async Task BulkSubmitAsync(IList<Event> events)
         {
             var cts = new CancellationTokenSource(_config.HttpClientTimeout);
-            StringContent stringContent = null;
+            var jsonEvents = "";
             try
             {
-                var json = JsonConvert.SerializeObject(events.ToList(), Formatting.None);
-                stringContent = new StringContent(json, Encoding.UTF8, "application/json");
+                jsonEvents = JsonConvert.SerializeObject(events.ToList(), Formatting.None);
                 Logger.LogDebug("Submitting " + events.Count + " events to " + _uri.AbsoluteUri + " with json: " +
-                                stringContent);
-                await SendEventsAsync(stringContent, cts);
+                                jsonEvents);
+                await SendEventsAsync(jsonEvents, cts);
             }
             catch (Exception e)
             {
@@ -90,8 +89,8 @@ private async Task BulkSubmitAsync(IList<Event> events)
                 try
                 {
                     Logger.LogDebug("Submitting " + events.Count + " events to " + _uri.AbsoluteUri + " with json: " +
-                                    stringContent);
-                    await SendEventsAsync(stringContent, cts);
+                                    jsonEvents);
+                    await SendEventsAsync(jsonEvents, cts);
                 }
                 catch (TaskCanceledException tce)
                 {
@@ -124,9 +123,10 @@ private async Task BulkSubmitAsync(IList<Event> events)
         }
 
 
-        private async Task SendEventsAsync(StringContent content, CancellationTokenSource cts)
+        private async Task SendEventsAsync(String jsonEvents, CancellationTokenSource cts)
         {
-            using (var response = await _httpClient.PostAsync(_uri, content).ConfigureAwait(false))
+            using (var stringContent = new StringContent(jsonEvents, Encoding.UTF8, "application/json"))
+            using (var response = await _httpClient.PostAsync(_uri, stringContent).ConfigureAwait(false))
             {
                 if (!response.IsSuccessStatusCode)
                 {

src/LaunchDarkly.Client/project.json

@@ -28,5 +28,5 @@
       }
     }
   },
-  "version": "3.1.0"
+  "version": "3.1.1"
 }