Desktop, Mobile: Fixes #11845: Fixes issues with converting nested lists between bullet and numbered.

[rabbabansh]

Fixes #11845 now, this"

• test
  • test
  • test
• test

converts to:

Checklists also convert nested lists fully, rather than just converting the first indent to checklists.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[rabbabansh]

I have read the CLA Document and I hereby sign the CLA.

[personalizedrefrigerator]

Thank you for working on this! Be sure to also update the automated tests in packages/editor/ with the expected output.

[rabbabansh]

Done! Please review

[personalizedrefrigerator]

Thank you! Be sure to update the existing tests, too — one is failing:

➤ YN0000: [@joplin/editor]:   FAIL CodeMirror/markdown/markdownCommands.toggleList.test.ts
➤ YN0000: [@joplin/editor]:   ● markdownCommands.toggleList › should toggle a numbered list without changing its sublists
➤ YN0000: [@joplin/editor]: 
➤ YN0000: [@joplin/editor]:     expect(received).toBe(expected) // Object.is equality
➤ YN0000: [@joplin/editor]: 
➤ YN0000: [@joplin/editor]:     - Expected  - 3
➤ YN0000: [@joplin/editor]:     + Received  + 3
➤ YN0000: [@joplin/editor]: 
➤ YN0000: [@joplin/editor]:       - [ ] Foo
➤ YN0000: [@joplin/editor]:       - [ ] Bar
➤ YN0000: [@joplin/editor]:       - [ ] Baz
➤ YN0000: [@joplin/editor]:     - 	- Test
➤ YN0000: [@joplin/editor]:     + 	- [ ] Test
➤ YN0000: [@joplin/editor]:     - 	- of
➤ YN0000: [@joplin/editor]:     + 	- [ ] of
➤ YN0000: [@joplin/editor]:     - 	- sublists
➤ YN0000: [@joplin/editor]:     + 	- [ ] sublists
➤ YN0000: [@joplin/editor]:       - [ ] Foo
➤ YN0000: [@joplin/editor]: 
➤ YN0000: [@joplin/editor]:       191 |
➤ YN0000: [@joplin/editor]:       192 | 		toggleList(ListType.CheckList)(editor);
➤ YN0000: [@joplin/editor]:     > 193 | 		expect(editor.state.doc.toString()).toBe(
➤ YN0000: [@joplin/editor]:           | 		                                    ^
➤ YN0000: [@joplin/editor]:       194 | 			'- [ ] Foo\n- [ ] Bar\n- [ ] Baz\n\t- Test\n\t- of\n\t- sublists\n- [ ] Foo',
➤ YN0000: [@joplin/editor]:       195 | 		);
➤ YN0000: [@joplin/editor]:       196 | 	});
➤ YN0000: [@joplin/editor]: 
➤ YN0000: [@joplin/editor]:       at Object.<anonymous> (CodeMirror/markdown/markdownCommands.toggleList.test.ts:193:39)

[rabbabansh]

That tests passes now! I rewrote the expected results for a nested checklist that gives checklists to the sublists as well.

[laurent22]

@personalizedrefrigerator, please let me know when you think it's ready to merge, as I don't know enough about the CM6 implementation to review